2018-10-19 14:27:54

by Liming Sun

Subject: [PATCH v1 1/1] mmc: dw_mmc-bluefield: simplify the probe() function

This commit removes the unnecessary of-node check since the
dw_mci_bluefield_match[] structure has only one entry.

Signed-off-by: Liming Sun <[email protected]>
---
drivers/mmc/host/dw_mmc-bluefield.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-bluefield.c b/drivers/mmc/host/dw_mmc-bluefield.c
index 54c3fbb..ed8f225 100644
--- a/drivers/mmc/host/dw_mmc-bluefield.c
+++ b/drivers/mmc/host/dw_mmc-bluefield.c
@@ -52,16 +52,7 @@ static void dw_mci_bluefield_set_ios(struct dw_mci *host, struct mmc_ios *ios)

static int dw_mci_bluefield_probe(struct platform_device *pdev)
{
- const struct dw_mci_drv_data *drv_data = NULL;
- const struct of_device_id *match;
-
- if (pdev->dev.of_node) {
- match = of_match_node(dw_mci_bluefield_match,
- pdev->dev.of_node);
- drv_data = match->data;
- }
-
- return dw_mci_pltfm_register(pdev, drv_data);
+ return dw_mci_pltfm_register(pdev, &bluefield_drv_data);
}

static struct platform_driver dw_mci_bluefield_pltfm_driver = {
--
1.8.3.1

2018-10-24 11:01:04

by Ulf Hansson

Subject: Re: [PATCH v1 1/1] mmc: dw_mmc-bluefield: simplify the probe() function

On 19 October 2018 at 16:26, Liming Sun <[email protected]> wrote:
> This commit removes the unnecessary of-node check since the
> dw_mci_bluefield_match[] structure has only one entry.
>
> Signed-off-by: Liming Sun <[email protected]>

Queued for 4.21, thanks!

Kind regards
Uffe

> ---
> drivers/mmc/host/dw_mmc-bluefield.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-bluefield.c b/drivers/mmc/host/dw_mmc-bluefield.c
> index 54c3fbb..ed8f225 100644
> --- a/drivers/mmc/host/dw_mmc-bluefield.c
> +++ b/drivers/mmc/host/dw_mmc-bluefield.c
> @@ -52,16 +52,7 @@ static void dw_mci_bluefield_set_ios(struct dw_mci *host, struct mmc_ios *ios)
>
> static int dw_mci_bluefield_probe(struct platform_device *pdev)
> {
> - const struct dw_mci_drv_data *drv_data = NULL;
> - const struct of_device_id *match;
> -
> - if (pdev->dev.of_node) {
> - match = of_match_node(dw_mci_bluefield_match,
> - pdev->dev.of_node);
> - drv_data = match->data;
> - }
> -
> - return dw_mci_pltfm_register(pdev, drv_data);
> + return dw_mci_pltfm_register(pdev, &bluefield_drv_data);
> }
>
> static struct platform_driver dw_mci_bluefield_pltfm_driver = {
> --
> 1.8.3.1
>