2022-09-13 04:08:40

by Yang Yingliang

Subject: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper

dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/clk/davinci/da8xx-cfgchip.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c
index 77d18276bfe8..4103d605e804 100644
--- a/drivers/clk/davinci/da8xx-cfgchip.c
+++ b/drivers/clk/davinci/da8xx-cfgchip.c
@@ -510,8 +510,7 @@ da8xx_cfgchip_register_usb0_clk48(struct device *dev,

fck_clk = devm_clk_get(dev, "fck");
if (IS_ERR(fck_clk)) {
- if (PTR_ERR(fck_clk) != -EPROBE_DEFER)
- dev_err(dev, "Missing fck clock\n");
+ dev_err_probe(dev, PTR_ERR(fck_clk), "Missing fck clock\n");
return ERR_CAST(fck_clk);
}

--
2.25.1

2022-09-13 17:28:10

by David Lechner

Subject: Re: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper

On 9/12/22 10:22 PM, Yang Yingliang wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---

Reviewed-by: David Lechner <[email protected]>

2022-09-30 21:09:27

by Stephen Boyd

Subject: Re: [PATCH -next] clk: davinci: cfgchip: Use dev_err_probe() helper

Quoting Yang Yingliang (2022-09-12 20:22:28)
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---

Applied to clk-next