2024-06-08 09:18:42

by Tejas Vipin

Subject: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

From: Tejas Vipin <[email protected]>
Subject: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to
mipi_dsi_msleep

mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a
value and not as a reference.

Signed-off-by: Tejas Vipin <[email protected]>
---
drivers/gpu/drm/panel/panel-himax-hx83102.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c b/drivers/gpu/drm/panel/panel-himax-hx83102.c
index 6009a3fe1b8f..ab00fd92cce0 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx83102.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c
@@ -479,7 +479,7 @@ static int hx83102_disable(struct drm_panel *panel)
mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);

- mipi_dsi_msleep(&dsi_ctx, 150);
+ mipi_dsi_msleep(dsi_ctx, 150);

return dsi_ctx.accum_err;
}
--
2.45.2

2024-06-11 07:52:57

by Neil Armstrong

Subject: Re: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep

On 08/06/2024 11:17, Tejas Vipin wrote:
>
> From: Tejas Vipin <[email protected]>
> Subject: [PATCH] drm/panel : himax-hx83102: fix incorrect argument to
> mipi_dsi_msleep
>
> mipi_dsi_msleep expects struct mipi_dsi_multi_context to be passed as a
> value and not as a reference.
>

Please add a Fixes tag

> Signed-off-by: Tejas Vipin <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-himax-hx83102.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c b/drivers/gpu/drm/panel/panel-himax-hx83102.c
> index 6009a3fe1b8f..ab00fd92cce0 100644
> --- a/drivers/gpu/drm/panel/panel-himax-hx83102.c
> +++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c
> @@ -479,7 +479,7 @@ static int hx83102_disable(struct drm_panel *panel)
> mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
> mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
>
> - mipi_dsi_msleep(&dsi_ctx, 150);
> + mipi_dsi_msleep(dsi_ctx, 150);
>
> return dsi_ctx.accum_err;
> }

Thanks,
Neil