Hello,
These are a few small changes for openrisc I would like to include in 4.10.
The main change is a fix for building with alldefconfig to properly setup
then _text symbol. Others are trivial.
If no complaints I will push to 4.10 for inclusion and start working on
4.11 changes.
Let me know if these are too minor to even post for review.
Stafford Horne (3):
openrisc: Add _text symbol to fix ksym build error
openrisc: Add .gitignore
MAINTAINERS: Add the openrisc official repository
MAINTAINERS | 1 +
arch/openrisc/kernel/.gitignore | 1 +
arch/openrisc/kernel/vmlinux.lds.S | 2 ++
3 files changed, 4 insertions(+)
create mode 100644 arch/openrisc/kernel/.gitignore
--
2.9.3
The build robot reports:
.tmp_kallsyms1.o: In function `kallsyms_relative_base':
>> (.rodata+0x8a18): undefined reference to `_text'
This is when using 'make alldefconfig'. Adding this _text symbol to mark
the start of the kernel as in other architecture fixes this.
Signed-off-by: Stafford Horne <[email protected]>
---
arch/openrisc/kernel/vmlinux.lds.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S
index ef31fc2..5525446 100644
--- a/arch/openrisc/kernel/vmlinux.lds.S
+++ b/arch/openrisc/kernel/vmlinux.lds.S
@@ -44,6 +44,8 @@ SECTIONS
/* Read-only sections, merged into text segment: */
. = LOAD_BASE ;
+ _text = .;
+
/* _s_kernel_ro must be page aligned */
. = ALIGN(PAGE_SIZE);
_s_kernel_ro = .;
--
2.9.3
This helps to suppress the vmlinux.lds file.
Signed-off-by: Stafford Horne <[email protected]>
---
arch/openrisc/kernel/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 arch/openrisc/kernel/.gitignore
diff --git a/arch/openrisc/kernel/.gitignore b/arch/openrisc/kernel/.gitignore
new file mode 100644
index 0000000..c5f676c
--- /dev/null
+++ b/arch/openrisc/kernel/.gitignore
@@ -0,0 +1 @@
+vmlinux.lds
--
2.9.3
The openrisc official repository and patch work happens currently on
github. Add the repo for reference.
Signed-off-by: Stafford Horne <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cfff2c9..d6ebe38 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9161,6 +9161,7 @@ OPENRISC ARCHITECTURE
M: Jonas Bonn <[email protected]>
M: Stefan Kristiansson <[email protected]>
M: Stafford Horne <[email protected]>
+T: git git://github.com/openrisc/linux.git
L: [email protected]
W: http://openrisc.io
S: Maintained
--
2.9.3
On 12/31/2016 12:52 PM, Stafford Horne wrote:
> The build robot reports:
>
> .tmp_kallsyms1.o: In function `kallsyms_relative_base':
>>> (.rodata+0x8a18): undefined reference to `_text'
> This is when using 'make alldefconfig'. Adding this _text symbol to mark
> the start of the kernel as in other architecture fixes this.
>
> Signed-off-by: Stafford Horne <[email protected]>
Acked-by: Jonas Bonn <[email protected]>
> ---
> arch/openrisc/kernel/vmlinux.lds.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S
> index ef31fc2..5525446 100644
> --- a/arch/openrisc/kernel/vmlinux.lds.S
> +++ b/arch/openrisc/kernel/vmlinux.lds.S
> @@ -44,6 +44,8 @@ SECTIONS
> /* Read-only sections, merged into text segment: */
> . = LOAD_BASE ;
>
> + _text = .;
> +
> /* _s_kernel_ro must be page aligned */
> . = ALIGN(PAGE_SIZE);
> _s_kernel_ro = .;
Hi Stafford,
On 12/31/2016 12:52 PM, Stafford Horne wrote:
> Hello,
>
> These are a few small changes for openrisc I would like to include in 4.10.
> The main change is a fix for building with alldefconfig to properly setup
> then _text symbol. Others are trivial.
>
> If no complaints I will push to 4.10 for inclusion and start working on
> 4.11 changes.
Post-merge window patches should be bug fixes, only. Patch 1/3
probably qualifies, but the others are far too trivial to be pushing
now. Just put them on your 4.11 branch.
>
> Let me know if these are too minor to even post for review.
Nothing is too minor to post for review!
/Jonas
>
> Stafford Horne (3):
> openrisc: Add _text symbol to fix ksym build error
> openrisc: Add .gitignore
> MAINTAINERS: Add the openrisc official repository
>
> MAINTAINERS | 1 +
> arch/openrisc/kernel/.gitignore | 1 +
> arch/openrisc/kernel/vmlinux.lds.S | 2 ++
> 3 files changed, 4 insertions(+)
> create mode 100644 arch/openrisc/kernel/.gitignore
>
Hi Jonas,
On Sat, Dec 31, 2016 at 03:10:37PM +0100, Jonas Bonn wrote:
> Hi Stafford,
>
> On 12/31/2016 12:52 PM, Stafford Horne wrote:
> > Hello,
> >
> > These are a few small changes for openrisc I would like to include in 4.10.
> > The main change is a fix for building with alldefconfig to properly setup
> > then _text symbol. Others are trivial.
> >
> > If no complaints I will push to 4.10 for inclusion and start working on
> > 4.11 changes.
>
> Post-merge window patches should be bug fixes, only. Patch 1/3 probably
> qualifies, but the others are far too trivial to be pushing now. Just put
> them on your 4.11 branch.
Thanks, for some reason I thought minor changes like this were ok too.
I will only push the one change in this case. The rest will go to my
4.11 queue, which I'll send for review in the next few days.
That brings up a question, Do you want to stay in the MAINTAINERS file?
I noticed sometimes you dont get around to review, but often when you do
the reviews are helpful like this one.
> > Let me know if these are too minor to even post for review.
> Nothing is too minor to post for review!
Good to know!
-Stafford
> >
> > Stafford Horne (3):
> > openrisc: Add _text symbol to fix ksym build error
> > openrisc: Add .gitignore
> > MAINTAINERS: Add the openrisc official repository
> >
> > MAINTAINERS | 1 +
> > arch/openrisc/kernel/.gitignore | 1 +
> > arch/openrisc/kernel/vmlinux.lds.S | 2 ++
> > 3 files changed, 4 insertions(+)
> > create mode 100644 arch/openrisc/kernel/.gitignore
> >
>