2019-09-05 06:15:14

by Ajay Singh

[permalink] [raw]
Subject: Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property

Hi Eugen,

On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <[email protected]>
>
> Add bindings for optional rtc clock pin.
>
> Signed-off-by: Eugen Hristev <[email protected]>

Thanks for sending the patch series. The changes in this series looks
good to me.

Acked-by: Ajay Singh <[email protected]>


Regards,
Ajay

> ---
> drivers/staging/wilc1000/microchip,wilc1000,sdio.txt | 8 +++++++-
> drivers/staging/wilc1000/microchip,wilc1000,spi.txt | 8 ++++++++
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt b/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
> index 4f7d1c2..da52359 100644
> --- a/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
> +++ b/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
> @@ -10,7 +10,9 @@ Required properties:
>
> Optional:
> - bus-width : Number of data lines wired up the slot. Default 1 bit.
> -
> +- rtc_clk : Clock connected on the rtc clock line. Must be assigned
> + a frequency with assigned-clocks property, and must be
> + connected to a clock provider.
>
> Examples:
> mmc1: mmc@fc000000 {
> @@ -24,6 +26,10 @@ mmc1: mmc@fc000000 {
> wilc_sdio@0 {
> compatible = "microchip,wilc1000-sdio";
> irq-gpios = <&pioC 27 0>;
> + clocks = <&pck1>;
> + clock-names = "rtc_clk";
> + assigned-clocks = <&pck1>;
> + assigned-clock-rates = <32768>;
> status = "okay";
> reg = <0>;
> bus-width = <4>;
> diff --git a/drivers/staging/wilc1000/microchip,wilc1000,spi.txt b/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
> index 87db87b..3423693 100644
> --- a/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
> +++ b/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
> @@ -9,6 +9,10 @@ Required properties:
> - reg : Chip select address of device
> - irq-gpios : Connect to a host IRQ
>
> +Optional:
> +- rtc_clk : Clock connected on the rtc clock line. Must be assigned
> + a frequency with assigned-clocks property, and must be
> + connected to a clock provider.
>
> Examples:
>
> @@ -21,6 +25,10 @@ spi1: spi@fc018000 {
> spi-max-frequency = <48000000>;
> reg = <0>;
> irq-gpios = <&pioC 27 0>;
> + clocks = <&pck1>;
> + clock-names = "rtc_clk";
> + assigned-clocks = <&pck1>;
> + assigned-clock-rates = <32768>;
> status = "okay";
> };
> };
>