2023-10-25 13:32:53

by Kathiravan Thirumoorthy

Subject: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED

Add support for wlan-2g LED on GPIO64.

Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
---
Changes in v2:
- Added function and color property
- Link to v1: https://lore.kernel.org/r/[email protected]
---
arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index 49c9b6478357..91e104b0f865 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -10,6 +10,7 @@

#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
#include "ipq9574.dtsi"

/ {
@@ -51,6 +52,20 @@ button-wps {
debounce-interval = <60>;
};
};
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&gpio_leds_default>;
+ pinctrl-names = "default";
+
+ led-0 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_WLAN;
+ gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+ };
};

&blsp1_spi0 {
@@ -117,6 +132,13 @@ gpio_keys_default: gpio-keys-default-state {
drive-strength = <8>;
bias-pull-up;
};
+
+ gpio_leds_default: gpio-leds-default-state {
+ pins = "gpio64";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
};

&usb_0_dwc3 {

---
base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
change-id: 20231025-ipq9574-led-8bdaab4c9cf6

Best regards,
--
Kathiravan Thirumoorthy <[email protected]>

2023-10-25 13:56:19

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED

On 25/10/2023 15:31, Kathiravan Thirumoorthy wrote:
> Add support for wlan-2g LED on GPIO64.
>
> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
> ---
> Changes in v2:
> - Added function and color property
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-12-01 13:39:18

by Kathiravan Thirumoorthy

Subject: Re: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED

On 10/25/2023 7:01 PM, Kathiravan Thirumoorthy wrote:
> Add support for wlan-2g LED on GPIO64.

Gentle Reminder...

>
> Signed-off-by: Kathiravan Thirumoorthy <[email protected]>
> ---
> Changes in v2:
> - Added function and color property
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index 49c9b6478357..91e104b0f865 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -10,6 +10,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> #include "ipq9574.dtsi"
>
> / {
> @@ -51,6 +52,20 @@ button-wps {
> debounce-interval = <60>;
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_WLAN;
> + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_spi0 {
> @@ -117,6 +132,13 @@ gpio_keys_default: gpio-keys-default-state {
> drive-strength = <8>;
> bias-pull-up;
> };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio64";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> };
>
> &usb_0_dwc3 {
>
> ---
> base-commit: fe1998aa935b44ef873193c0772c43bce74f17dc
> change-id: 20231025-ipq9574-led-8bdaab4c9cf6
>
> Best regards,

2023-12-08 02:56:05

by Bjorn Andersson

Subject: Re: [PATCH v2] arm64: dts: qcom: ipq9574: enable GPIO based LED

On Wed, 25 Oct 2023 19:01:25 +0530, Kathiravan Thirumoorthy wrote:
> Add support for wlan-2g LED on GPIO64.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: ipq9574: enable GPIO based LED
commit: 2928212b6ef24d6a4f2af849157ac18546030b97

Best regards,
--
Bjorn Andersson <[email protected]>