2022-06-13 21:00:38

by andrey.konovalov

Subject: [PATCH 09/32] kasan: clear metadata functions for tag-based modes

From: Andrey Konovalov <[email protected]>

Remove implementations of the metadata-related functions for the tag-based
modes.

The following patches in the series will provide alternative
implementations.

As of this patch, the tag-based modes no longer collect alloc and free
stack traces. This functionality will be restored later in the series.

Signed-off-by: Andrey Konovalov <[email protected]>
---
mm/kasan/tags.c | 33 ++-------------------------------
1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c
index 2e200969a4b8..f11c89505c77 100644
--- a/mm/kasan/tags.c
+++ b/mm/kasan/tags.c
@@ -19,54 +19,25 @@

void kasan_init_object_meta(struct kmem_cache *cache, const void *object)
{
- struct kasan_alloc_meta *alloc_meta;
-
- alloc_meta = kasan_get_alloc_meta(cache, object);
- if (alloc_meta)
- __memset(alloc_meta, 0, sizeof(*alloc_meta));
}

void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags)
{
- struct kasan_alloc_meta *alloc_meta;
-
- alloc_meta = kasan_get_alloc_meta(cache, object);
- if (alloc_meta)
- kasan_set_track(&alloc_meta->alloc_track, flags);
}

void kasan_save_free_info(struct kmem_cache *cache,
void *object, u8 tag)
{
- struct kasan_alloc_meta *alloc_meta;
-
- alloc_meta = kasan_get_alloc_meta(cache, object);
- if (!alloc_meta)
- return;
-
- kasan_set_track(&alloc_meta->free_track, GFP_NOWAIT);
}

struct kasan_track *kasan_get_alloc_track(struct kmem_cache *cache,
void *object)
{
- struct kasan_alloc_meta *alloc_meta;
-
- alloc_meta = kasan_get_alloc_meta(cache, object);
- if (!alloc_meta)
- return NULL;
-
- return &alloc_meta->alloc_track;
+ return NULL;
}

struct kasan_track *kasan_get_free_track(struct kmem_cache *cache,
void *object, u8 tag)
{
- struct kasan_alloc_meta *alloc_meta;
-
- alloc_meta = kasan_get_alloc_meta(cache, object);
- if (!alloc_meta)
- return NULL;
-
- return &alloc_meta->free_track;
+ return NULL;
}
--
2.25.1

2022-06-20 15:29:25

by Marco Elver

Subject: Re: [PATCH 09/32] kasan: clear metadata functions for tag-based modes

On Mon, 13 Jun 2022 at 22:16, <[email protected]> wrote:
>
> From: Andrey Konovalov <[email protected]>
>
> Remove implementations of the metadata-related functions for the tag-based
> modes.
>
> The following patches in the series will provide alternative
> implementations.
>
> As of this patch, the tag-based modes no longer collect alloc and free
> stack traces. This functionality will be restored later in the series.
>
> Signed-off-by: Andrey Konovalov <[email protected]>

Reviewed-by: Marco Elver <[email protected]>


> ---
> mm/kasan/tags.c | 33 ++-------------------------------
> 1 file changed, 2 insertions(+), 31 deletions(-)
>
> diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c
> index 2e200969a4b8..f11c89505c77 100644
> --- a/mm/kasan/tags.c
> +++ b/mm/kasan/tags.c
> @@ -19,54 +19,25 @@
>
> void kasan_init_object_meta(struct kmem_cache *cache, const void *object)
> {
> - struct kasan_alloc_meta *alloc_meta;
> -
> - alloc_meta = kasan_get_alloc_meta(cache, object);
> - if (alloc_meta)
> - __memset(alloc_meta, 0, sizeof(*alloc_meta));
> }
>
> void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags)
> {
> - struct kasan_alloc_meta *alloc_meta;
> -
> - alloc_meta = kasan_get_alloc_meta(cache, object);
> - if (alloc_meta)
> - kasan_set_track(&alloc_meta->alloc_track, flags);
> }
>
> void kasan_save_free_info(struct kmem_cache *cache,
> void *object, u8 tag)
> {
> - struct kasan_alloc_meta *alloc_meta;
> -
> - alloc_meta = kasan_get_alloc_meta(cache, object);
> - if (!alloc_meta)
> - return;
> -
> - kasan_set_track(&alloc_meta->free_track, GFP_NOWAIT);
> }
>
> struct kasan_track *kasan_get_alloc_track(struct kmem_cache *cache,
> void *object)
> {
> - struct kasan_alloc_meta *alloc_meta;
> -
> - alloc_meta = kasan_get_alloc_meta(cache, object);
> - if (!alloc_meta)
> - return NULL;
> -
> - return &alloc_meta->alloc_track;
> + return NULL;
> }
>
> struct kasan_track *kasan_get_free_track(struct kmem_cache *cache,
> void *object, u8 tag)
> {
> - struct kasan_alloc_meta *alloc_meta;
> -
> - alloc_meta = kasan_get_alloc_meta(cache, object);
> - if (!alloc_meta)
> - return NULL;
> -
> - return &alloc_meta->free_track;
> + return NULL;
> }
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/db6ce7b46d47aa26056e9eae5c2aa49a3160a566.1655150842.git.andreyknvl%40google.com.