2020-01-30 12:57:02

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] mfd: syscon: Fix syscon_regmap_lookup_by_phandle_args() dummy

If CONFIG_MFD_SYSCON=n:

include/linux/mfd/syscon.h:54:23: warning: ‘syscon_regmap_lookup_by_phandle_args’ defined but not used [-Wunused-function]

Fix this by adding the missing inline keyword.

Fixes: 6a24f567af4accef ("mfd: syscon: Add arguments support for syscon reference")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
include/linux/mfd/syscon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
index 714cab1e09d3c1fd..7f20e9b502a5bd48 100644
--- a/include/linux/mfd/syscon.h
+++ b/include/linux/mfd/syscon.h
@@ -51,7 +51,7 @@ static inline struct regmap *syscon_regmap_lookup_by_phandle(
return ERR_PTR(-ENOTSUPP);
}

-static struct regmap *syscon_regmap_lookup_by_phandle_args(
+static inline struct regmap *syscon_regmap_lookup_by_phandle_args(
struct device_node *np,
const char *property,
int arg_count,
--
2.17.1


2020-01-30 17:01:41

by 翟京 (Orson Zhai)

[permalink] [raw]
Subject: 答复: [PATCH] mfd: syscon: Fix syscon_regmap_ lookup_by_phandle_args() dummy

Sorry, I missed it.

Thank you Geert!

Best,
-Orson


________________________________________
??????: Geert Uytterhoeven <[email protected]>
????ʱ??: 2020??1??30?? 20:55
?ռ???: ?Ծ? (Orson Zhai); Lee Jones
????: Arnd Bergmann; [email protected]; Geert Uytterhoeven
????: [PATCH] mfd: syscon: Fix syscon_regmap_lookup_by_phandle_args() dummy

If CONFIG_MFD_SYSCON=n:

include/linux/mfd/syscon.h:54:23: warning: ??syscon_regmap_lookup_by_phandle_args?? defined but not used [-Wunused-function]

Fix this by adding the missing inline keyword.

Fixes: 6a24f567af4accef ("mfd: syscon: Add arguments support for syscon reference")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
include/linux/mfd/syscon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
index 714cab1e09d3c1fd..7f20e9b502a5bd48 100644
--- a/include/linux/mfd/syscon.h
+++ b/include/linux/mfd/syscon.h
@@ -51,7 +51,7 @@ static inline struct regmap *syscon_regmap_lookup_by_phandle(
return ERR_PTR(-ENOTSUPP);
}

-static struct regmap *syscon_regmap_lookup_by_phandle_args(
+static inline struct regmap *syscon_regmap_lookup_by_phandle_args(
struct device_node *np,
const char *property,
int arg_count,
--
2.17.1

________________________________
This email (including its attachments) is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorized use, dissemination, distribution or copying of this email or the information herein or taking any action in reliance on the contents of this email or the information herein, by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is strictly prohibited. If you are not the intended recipient, please do not read, copy, use or disclose any part of this e-mail to others. Please notify the sender immediately and permanently delete this e-mail and any attachments if you received it in error. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender does not accept liability for any errors or omissions.
???ʼ????丽?????б??????ʣ??ܷ??ɱ???????й¶???????͸????ʼ???ָ?ض??ռ??ˡ??Ͻ??Ǿ???Ȩʹ?á????????????????Ʊ??ʼ????????ݡ????Ǹ??ض??ռ??ˣ??????Ķ??????ơ? ʹ?û???¶???ʼ????κ????ݡ??????ձ??ʼ???????ϵͳ????????ɾ?????ʼ??????и????????Իظ??ʼ??ķ?ʽ???̸?֪?????ˡ??޷???֤??????ͨ?ż?ʱ????ȫ???????????????????˶??κδ?©?????е????Ρ?

2020-02-03 10:01:20

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: syscon: Fix syscon_regmap_lookup_by_phandle_args() dummy

On Thu, 30 Jan 2020, Geert Uytterhoeven wrote:

> If CONFIG_MFD_SYSCON=n:
>
> include/linux/mfd/syscon.h:54:23: warning: ‘syscon_regmap_lookup_by_phandle_args’ defined but not used [-Wunused-function]
>
> Fix this by adding the missing inline keyword.
>
> Fixes: 6a24f567af4accef ("mfd: syscon: Add arguments support for syscon reference")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> include/linux/mfd/syscon.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog