This patch fixes the error checking in ucd9000.c.
The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.
Signed-off-by: Osama Muhammad <[email protected]>
---
drivers/hwmon/pmbus/ucd9000.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
index 3daaf2237832..73559afa8ba7 100644
--- a/drivers/hwmon/pmbus/ucd9000.c
+++ b/drivers/hwmon/pmbus/ucd9000.c
@@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
return -ENOENT;
data->debugfs = debugfs_create_dir(client->name, debugfs);
- if (!data->debugfs)
- return -ENOENT;
/*
* Of the chips this driver supports, only the UCD9090, UCD90160,
--
2.34.1
On Thu, May 25, 2023 at 09:13:13PM +0500, Osama Muhammad wrote:
> This patch fixes the error checking in ucd9000.c.
Sure, but you should also explain what is wrong with the code
(i.e., that debugfs_create_dir() does not return NULL but an ERR_PTR
after an error).
> The DebugFS kernel API is developed in
> a way that the caller can safely ignore the errors that
> occur during the creation of DebugFS nodes.
>
If you plan t send more patches, please watch out for the subject line
to match subject lines used in a subsystem. Here it should start with
something like
hwmon: (pmbus/ucd9000) ...
Thanks,
Guenter
> Signed-off-by: Osama Muhammad <[email protected]>
> ---
> drivers/hwmon/pmbus/ucd9000.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
> index 3daaf2237832..73559afa8ba7 100644
> --- a/drivers/hwmon/pmbus/ucd9000.c
> +++ b/drivers/hwmon/pmbus/ucd9000.c
> @@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
> return -ENOENT;
>
> data->debugfs = debugfs_create_dir(client->name, debugfs);
> - if (!data->debugfs)
> - return -ENOENT;
>
> /*
> * Of the chips this driver supports, only the UCD9090, UCD90160,
> --
> 2.34.1
>
On Thu, May 25, 2023 at 11:36:51PM +0500, Osama Muhammad wrote:
> On Thu, 25 May 2023 at 23:21, Guenter Roeck <[email protected]> wrote:
>
> > On Thu, May 25, 2023 at 09:13:13PM +0500, Osama Muhammad wrote:
> > > This patch fixes the error checking in ucd9000.c.
> >
> > Sure, but you should also explain what is wrong with the code
> > (i.e., that debugfs_create_dir() does not return NULL but an ERR_PTR
> > after an error).
> >
> Should I send another version of the patch?
>
Please do.
Guenter
>
> >
> > > The DebugFS kernel API is developed in
> > > a way that the caller can safely ignore the errors that
> > > occur during the creation of DebugFS nodes.
> > >
> >
> > If you plan t send more patches, please watch out for the subject line
> > to match subject lines used in a subsystem. Here it should start with
> > something like
> >
> > hwmon: (pmbus/ucd9000) ...
> >
> > Thanks for the information and will keep it in mind while sending patches
> afterwards.
>
> > Thanks,
> > Guenter
> >
> > > Signed-off-by: Osama Muhammad <[email protected]>
> > > ---
> > > drivers/hwmon/pmbus/ucd9000.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/hwmon/pmbus/ucd9000.c
> > b/drivers/hwmon/pmbus/ucd9000.c
> > > index 3daaf2237832..73559afa8ba7 100644
> > > --- a/drivers/hwmon/pmbus/ucd9000.c
> > > +++ b/drivers/hwmon/pmbus/ucd9000.c
> > > @@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client
> > *client,
> > > return -ENOENT;
> > >
> > > data->debugfs = debugfs_create_dir(client->name, debugfs);
> > > - if (!data->debugfs)
> > > - return -ENOENT;
> > >
> > > /*
> > > * Of the chips this driver supports, only the UCD9090, UCD90160,
> > > --
> > > 2.34.1
> > >
>
>
> Thanks,
> Osmten