2021-03-22 21:13:44

by Andy Shevchenko

Subject: [PATCH v1 4/6] usb: gadget: pch_udc: Move pch_udc_init() to satisfy kernel doc

Kernel doc and the content described by it shouldn't be teared apart.
Otherwise validator is not happy:

.../pch_udc.c:573: warning: expecting prototype for pch_udc_reconnect(). Prototype was for pch_udc_init() instead

Fixes: 1c575d2d2e3f ("usb: gadget: pch_udc: Fix usb/gadget/pch_udc: Fix ether gadget connect/disconnect issue")
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/usb/gadget/udc/pch_udc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c
index 5421075df01c..984c9299d2c6 100644
--- a/drivers/usb/gadget/udc/pch_udc.c
+++ b/drivers/usb/gadget/udc/pch_udc.c
@@ -563,12 +563,13 @@ static void pch_udc_clear_disconnect(struct pch_udc_dev *dev)
pch_udc_bit_clr(dev, UDC_DEVCTL_ADDR, UDC_DEVCTL_RES);
}

+static void pch_udc_init(struct pch_udc_dev *dev);
+
/**
* pch_udc_reconnect() - This API initializes usb device controller,
* and clear the disconnect status.
* @dev: Reference to pch_udc_regs structure
*/
-static void pch_udc_init(struct pch_udc_dev *dev);
static void pch_udc_reconnect(struct pch_udc_dev *dev)
{
pch_udc_init(dev);
--
2.30.2

2021-03-23 09:48:27

by Sergei Shtylyov

Subject: Re: [PATCH v1 4/6] usb: gadget: pch_udc: Move pch_udc_init() to satisfy kernel doc

Hi!

On 23.03.2021 0:11, Andy Shevchenko wrote:

> Kernel doc and the content described by it shouldn't be teared apart.

s/teared/torn/?

> Otherwise validator is not happy:
>
> .../pch_udc.c:573: warning: expecting prototype for pch_udc_reconnect(). Prototype was for pch_udc_init() instead
>
> Fixes: 1c575d2d2e3f ("usb: gadget: pch_udc: Fix usb/gadget/pch_udc: Fix ether gadget connect/disconnect issue")
> Signed-off-by: Andy Shevchenko <[email protected]>
[...]

MBR, Sergei

2021-03-23 10:38:25

by Andy Shevchenko

Subject: Re: [PATCH v1 4/6] usb: gadget: pch_udc: Move pch_udc_init() to satisfy kernel doc

On Tue, Mar 23, 2021 at 11:46 AM Sergei Shtylyov
<[email protected]> wrote:
> On 23.03.2021 0:11, Andy Shevchenko wrote:
>
> > Kernel doc and the content described by it shouldn't be teared apart.
>
> s/teared/torn/?

Thanks!
I will change if the maintainer asks to resend or if it will be
another version for some other reason.


--
With Best Regards,
Andy Shevchenko