2023-05-17 13:57:38

by Raphael Gallais-Pou

[permalink] [raw]
Subject: [PATCH 0/3] STM32 warning cleanup

This serie aims to reduce the number of device-tree warnings of
following boards :

- STM32F429-DISCO
- STM32MP15*

Those warnings were appearing either during build or when checking
dt-bindings and concern mostly LTDC and DSI IPs and were due to the
following cases:

- panel-dsi@0 nodes that needed
- unnecessary #address-cells and #size-cells properties
- residual 'reg' field on single endpoints

Raphael Gallais-Pou (3):
ARM: dts: stm32: fix warnings on stm32f469-disco board
dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
ARM: dts: stm32: fix several DT warnings on stm32mp15

.../devicetree/bindings/display/st,stm32-dsi.yaml | 2 --
arch/arm/boot/dts/stm32f469-disco.dts | 4 ++--
arch/arm/boot/dts/stm32mp151.dtsi | 5 -----
arch/arm/boot/dts/stm32mp157.dtsi | 7 -------
.../dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts | 6 ++++--
.../boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts | 6 ++++--
.../stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts | 3 +--
arch/arm/boot/dts/stm32mp157c-dk2.dts | 8 ++++++++
arch/arm/boot/dts/stm32mp157c-ev1.dts | 10 +++++++---
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 3 +--
arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 6 +-----
arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 3 +--
12 files changed, 29 insertions(+), 34 deletions(-)

--
2.25.1



2023-05-17 14:04:57

by Raphael Gallais-Pou

[permalink] [raw]
Subject: [PATCH 1/3] ARM: dts: stm32: fix warnings on stm32f469-disco board

Several warnings appear when building and checking stm32f429 device-tree:

arch/arm/boot/dts/stm32f469-disco.dts:182.28-184.5: Warning (unit_address_vs_reg): /soc/display-controller@40016800/port/endpoint@0: node has a unit name, but no reg or ranges property

.../arch/arm/boot/dts/stm32f469-disco.dtb: dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was unexpected)
From schema: .../Documentation/devicetree/bindings/display/st,stm32-dsi.yaml

Fix those.

Signed-off-by: Raphael Gallais-Pou <[email protected]>
---
arch/arm/boot/dts/stm32f469-disco.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch/arm/boot/dts/stm32f469-disco.dts
index 5a0daf8e8b11..cbbd521bf010 100644
--- a/arch/arm/boot/dts/stm32f469-disco.dts
+++ b/arch/arm/boot/dts/stm32f469-disco.dts
@@ -160,7 +160,7 @@ dsi_out: endpoint {
};
};

- panel-dsi@0 {
+ panel@0 {
compatible = "orisetech,otm8009a";
reg = <0>; /* dsi virtual channel (0..3) */
reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
@@ -179,7 +179,7 @@ &ltdc {
status = "okay";

port {
- ltdc_out_dsi: endpoint@0 {
+ ltdc_out_dsi: endpoint {
remote-endpoint = <&dsi_in>;
};
};
--
2.25.1


2023-05-17 14:23:54

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH 0/3] STM32 warning cleanup

On 5/17/23 15:22, Raphael Gallais-Pou wrote:
> This serie aims to reduce the number of device-tree warnings of
> following boards :
>
> - STM32F429-DISCO
> - STM32MP15*
>
> Those warnings were appearing either during build or when checking
> dt-bindings and concern mostly LTDC and DSI IPs and were due to the
> following cases:
>
> - panel-dsi@0 nodes that needed
> - unnecessary #address-cells and #size-cells properties
> - residual 'reg' field on single endpoints
>
> Raphael Gallais-Pou (3):
> ARM: dts: stm32: fix warnings on stm32f469-disco board
> dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
> ARM: dts: stm32: fix several DT warnings on stm32mp15
>
> .../devicetree/bindings/display/st,stm32-dsi.yaml | 2 --
> arch/arm/boot/dts/stm32f469-disco.dts | 4 ++--
> arch/arm/boot/dts/stm32mp151.dtsi | 5 -----
> arch/arm/boot/dts/stm32mp157.dtsi | 7 -------
> .../dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts | 6 ++++--
> .../boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts | 6 ++++--
> .../stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts | 3 +--
> arch/arm/boot/dts/stm32mp157c-dk2.dts | 8 ++++++++
> arch/arm/boot/dts/stm32mp157c-ev1.dts | 10 +++++++---
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 3 +--
> arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 6 +-----
> arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 3 +--
> 12 files changed, 29 insertions(+), 34 deletions(-)
>

Is this a V2 series ?

If so, please do include changelog .

Also, use "git send-email -v2" to mark those patches as v2 automatically
when sending .

2023-05-17 14:53:23

by Raphael Gallais-Pou

[permalink] [raw]
Subject: Re: [PATCH 0/3] STM32 warning cleanup


On 5/17/23 16:06, Marek Vasut wrote:
> On 5/17/23 15:22, Raphael Gallais-Pou wrote:
>> This serie aims to reduce the number of device-tree warnings of
>> following boards :
>>
>>    - STM32F429-DISCO
>>    - STM32MP15*
>>
>> Those warnings were appearing either during build or when checking
>> dt-bindings and concern mostly LTDC and DSI IPs and were due to the
>> following cases:
>>
>>    - panel-dsi@0 nodes that needed
>>    - unnecessary #address-cells and #size-cells properties
>>    - residual 'reg' field on single endpoints
>>
>> Raphael Gallais-Pou (3):
>>    ARM: dts: stm32: fix warnings on stm32f469-disco board
>>    dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
>>    ARM: dts: stm32: fix several DT warnings on stm32mp15
>>
>>   .../devicetree/bindings/display/st,stm32-dsi.yaml      |  2 --
>>   arch/arm/boot/dts/stm32f469-disco.dts                  |  4 ++--
>>   arch/arm/boot/dts/stm32mp151.dtsi                      |  5 -----
>>   arch/arm/boot/dts/stm32mp157.dtsi                      |  7 -------
>>   .../dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts    |  6 ++++--
>>   .../boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts   |  6 ++++--
>>   .../stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts  |  3 +--
>>   arch/arm/boot/dts/stm32mp157c-dk2.dts                  |  8 ++++++++
>>   arch/arm/boot/dts/stm32mp157c-ev1.dts                  | 10 +++++++---
>>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts              |  3 +--
>>   arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi     |  6 +-----
>>   arch/arm/boot/dts/stm32mp15xx-dkx.dtsi                 |  3 +--
>>   12 files changed, 29 insertions(+), 34 deletions(-)
>>
>
> Is this a V2 series ?

Hi Marek


yes it was,

Thanks for highlighting it to me.

Raphaël

>
> If so, please do include changelog .
>
> Also, use "git send-email -v2" to mark those patches as v2 automatically when
> sending .

2023-05-17 15:51:07

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH 0/3] STM32 warning cleanup

On 5/17/23 16:38, Raphael Gallais-Pou wrote:
>
> On 5/17/23 16:06, Marek Vasut wrote:
>> On 5/17/23 15:22, Raphael Gallais-Pou wrote:
>>> This serie aims to reduce the number of device-tree warnings of
>>> following boards :
>>>
>>>    - STM32F429-DISCO
>>>    - STM32MP15*
>>>
>>> Those warnings were appearing either during build or when checking
>>> dt-bindings and concern mostly LTDC and DSI IPs and were due to the
>>> following cases:
>>>
>>>    - panel-dsi@0 nodes that needed
>>>    - unnecessary #address-cells and #size-cells properties
>>>    - residual 'reg' field on single endpoints
>>>
>>> Raphael Gallais-Pou (3):
>>>    ARM: dts: stm32: fix warnings on stm32f469-disco board
>>>    dt-bindings: display: st,stm32-dsi: Remove unnecessary fields
>>>    ARM: dts: stm32: fix several DT warnings on stm32mp15
>>>
>>>   .../devicetree/bindings/display/st,stm32-dsi.yaml      |  2 --
>>>   arch/arm/boot/dts/stm32f469-disco.dts                  |  4 ++--
>>>   arch/arm/boot/dts/stm32mp151.dtsi                      |  5 -----
>>>   arch/arm/boot/dts/stm32mp157.dtsi                      |  7 -------
>>>   .../dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts    |  6 ++++--
>>>   .../boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts   |  6 ++++--
>>>   .../stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts  |  3 +--
>>>   arch/arm/boot/dts/stm32mp157c-dk2.dts                  |  8 ++++++++
>>>   arch/arm/boot/dts/stm32mp157c-ev1.dts                  | 10 +++++++---
>>>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts              |  3 +--
>>>   arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi     |  6 +-----
>>>   arch/arm/boot/dts/stm32mp15xx-dkx.dtsi                 |  3 +--
>>>   12 files changed, 29 insertions(+), 34 deletions(-)
>>>
>>
>> Is this a V2 series ?
>
> Hi Marek
>
>
> yes it was,
>
> Thanks for highlighting it to me.

You're welcome, I see a V3 now, thanks !