2021-03-15 10:47:03

by Srinivas Kandagatla

[permalink] [raw]
Subject: [PATCH] nvmem: rmem: fix undefined reference to memremap

Fix below error reporte by kernel test robot
rmem.c:(.text+0x14e): undefined reference to memremap
s390x-linux-gnu-ld: rmem.c:(.text+0x1b6): undefined reference to memunmap

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/nvmem/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 642ddc699fd1..dd2019006838 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -272,6 +272,7 @@ config SPRD_EFUSE

config NVMEM_RMEM
tristate "Reserved Memory Based Driver Support"
+ depends on HAS_IOMEM
help
This driver maps reserved memory into an nvmem device. It might be
useful to expose information left by firmware in memory.
--
2.21.0


2021-03-15 10:48:45

by Nicolas Saenz Julienne

[permalink] [raw]
Subject: Re: [PATCH] nvmem: rmem: fix undefined reference to memremap

On Mon, 2021-03-15 at 10:44 +0000, Srinivas Kandagatla wrote:
> Fix below error reporte by kernel test robot
> rmem.c:(.text+0x14e): undefined reference to memremap
> s390x-linux-gnu-ld: rmem.c:(.text+0x1b6): undefined reference to memunmap
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Srinivas Kandagatla <[email protected]>
> ---

Reviewed-by: Nicolas Saenz Julienne <[email protected]>

Thanks!

>  drivers/nvmem/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 642ddc699fd1..dd2019006838 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -272,6 +272,7 @@ config SPRD_EFUSE
>  
>
>  config NVMEM_RMEM
>   tristate "Reserved Memory Based Driver Support"
> + depends on HAS_IOMEM
>   help
>   This driver maps reserved memory into an nvmem device. It might be
>   useful to expose information left by firmware in memory.



Attachments:
signature.asc (499.00 B)
This is a digitally signed message part