2021-11-24 02:02:23

by Yang Li

Subject: [PATCH -next] asus-wmi: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/platform/x86/asus-wmi.c:2386:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/platform/x86/asus-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index ab0c087..6fa4b0b 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -2383,7 +2383,7 @@ static ssize_t fan_curve_enable_store(struct device *dev,
break;
default:
return -EINVAL;
- };
+ }

if (data->enabled) {
err = fan_curve_write(asus, data);
--
1.8.3.1

2021-11-25 15:38:12

by Hans de Goede

Subject: Re: [PATCH -next] asus-wmi: remove unneeded semicolon

Hi,

On 11/24/21 03:02, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/platform/x86/asus-wmi.c:2386:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
> drivers/platform/x86/asus-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index ab0c087..6fa4b0b 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -2383,7 +2383,7 @@ static ssize_t fan_curve_enable_store(struct device *dev,
> break;
> default:
> return -EINVAL;
> - };
> + }
>
> if (data->enabled) {
> err = fan_curve_write(asus, data);
>