2023-09-29 09:07:56

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] m68k: defconfig: Update virt_defconfig for v6.6-rc3

- Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
Kconfig defaults")),
- Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Perhaps CONFIG_FB_DEVICE should not be enabled?

To be queued in the m68k for-v6.7 branch.
---
arch/m68k/configs/virt_defconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/m68k/configs/virt_defconfig b/arch/m68k/configs/virt_defconfig
index 3afc6762b0946aa6..ec021a1d48ee7d86 100644
--- a/arch/m68k/configs/virt_defconfig
+++ b/arch/m68k/configs/virt_defconfig
@@ -47,8 +47,9 @@ CONFIG_INPUT_EVDEV=y
CONFIG_VIRTIO_CONSOLE=y
CONFIG_HW_RANDOM_VIRTIO=y
CONFIG_DRM=y
+CONFIG_DRM_FBDEV_EMULATION=y
CONFIG_DRM_VIRTIO_GPU=y
-CONFIG_FRAMEBUFFER_CONSOLE=y
+CONFIG_FB_DEVICE=y
CONFIG_SOUND=y
CONFIG_SND=y
CONFIG_SND_VIRTIO=y
--
2.34.1


2023-09-29 09:56:43

by Laurent Vivier

[permalink] [raw]
Subject: Re: [PATCH] m68k: defconfig: Update virt_defconfig for v6.6-rc3

Le 29/09/2023 à 11:01, Geert Uytterhoeven a écrit :
> - Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
> auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
> Kconfig defaults")),
> - Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
> bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Perhaps CONFIG_FB_DEVICE should not be enabled?

Why do you think it should not be enabled?

I think X was needing this to work on m68k.

Thanks,
Laurent

>
> To be queued in the m68k for-v6.7 branch.
> ---
> arch/m68k/configs/virt_defconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/m68k/configs/virt_defconfig b/arch/m68k/configs/virt_defconfig
> index 3afc6762b0946aa6..ec021a1d48ee7d86 100644
> --- a/arch/m68k/configs/virt_defconfig
> +++ b/arch/m68k/configs/virt_defconfig
> @@ -47,8 +47,9 @@ CONFIG_INPUT_EVDEV=y
> CONFIG_VIRTIO_CONSOLE=y
> CONFIG_HW_RANDOM_VIRTIO=y
> CONFIG_DRM=y
> +CONFIG_DRM_FBDEV_EMULATION=y
> CONFIG_DRM_VIRTIO_GPU=y
> -CONFIG_FRAMEBUFFER_CONSOLE=y
> +CONFIG_FB_DEVICE=y
> CONFIG_SOUND=y
> CONFIG_SND=y
> CONFIG_SND_VIRTIO=y

2023-09-29 10:04:19

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] m68k: defconfig: Update virt_defconfig for v6.6-rc3

Hi Laurent,

On Fri, Sep 29, 2023 at 11:44 AM Laurent Vivier <[email protected]> wrote:
> Le 29/09/2023 à 11:01, Geert Uytterhoeven a écrit :
> > - Enable CONFIG_DRM_FBDEV_EMULATION and CONFIG_FB_DEVICE (no longer
> > auto-enabled since commit bb6c4507fe825f1b ("drm: fix up fbdev
> > Kconfig defaults")),
> > - Drop CONFIG_FRAMEBUFFER_CONSOLE=y (auto-enabled since commit
> > bb6c4507fe825f1b ("drm: fix up fbdev Kconfig defaults")).
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > Perhaps CONFIG_FB_DEVICE should not be enabled?
>
> Why do you think it should not be enabled?

Because virt uses virtio_gpudrm.

> I think X was needing this to work on m68k.

Perhaps a version of X or Wayland can work with virtio_gpudrm
directly, without needing DRM's fbdev emulation and /dev/fb0?

DRM's fbdev emulation is still needed for the text console, of course.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds