2015-06-24 08:41:11

by Michal Simek

Subject: [PATCH 1/3] phy: berlin: .owner field is setup by core

There was big cleanup in past to remove this unneeded setting.

Signed-off-by: Michal Simek <[email protected]>
---

Can be also tracked by coccinelle script.
scripts/coccinelle/api/platform_no_drv_owner.cocci

---
drivers/phy/phy-berlin-usb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index c6fc95b53083..d7431f6ab975 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -207,7 +207,6 @@ static struct platform_driver phy_berlin_usb_driver = {
.probe = phy_berlin_usb_probe,
.driver = {
.name = "phy-berlin-usb",
- .owner = THIS_MODULE,
.of_match_table = phy_berlin_sata_of_match,
},
};
--
2.3.5

2015-06-24 08:41:46

by Michal Simek

Subject: [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver

c&p error from berlin sata phy driver.

Signed-off-by: Michal Simek <[email protected]>
---

drivers/phy/phy-berlin-usb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index d7431f6ab975..762f0fbdc119 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
.owner = THIS_MODULE,
};

-static const struct of_device_id phy_berlin_sata_of_match[] = {
+static const struct of_device_id phy_berlin_usb_of_match[] = {
{
.compatible = "marvell,berlin2-usb-phy",
.data = &phy_berlin_pll_dividers[0],
@@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
},
{ },
};
-MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
+MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);

static int phy_berlin_usb_probe(struct platform_device *pdev)
{
const struct of_device_id *match =
- of_match_device(phy_berlin_sata_of_match, &pdev->dev);
+ of_match_device(phy_berlin_usb_of_match, &pdev->dev);
struct phy_berlin_usb_priv *priv;
struct resource *res;
struct phy *phy;
@@ -207,7 +207,7 @@ static struct platform_driver phy_berlin_usb_driver = {
.probe = phy_berlin_usb_probe,
.driver = {
.name = "phy-berlin-usb",
- .of_match_table = phy_berlin_sata_of_match,
+ .of_match_table = phy_berlin_usb_of_match,
},
};
module_platform_driver(phy_berlin_usb_driver);
--
2.3.5

2015-06-24 08:41:22

by Michal Simek

Subject: [PATCH 3/3] usb: berlin: Trivial coding style cleanup

Remove unneeded space after tab.

Signed-off-by: Michal Simek <[email protected]>
---

drivers/phy/phy-berlin-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index 762f0fbdc119..0fe0d81c29ee 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
.driver = {
.name = "phy-berlin-usb",
.of_match_table = phy_berlin_usb_of_match,
- },
+ },
};
module_platform_driver(phy_berlin_usb_driver);

--
2.3.5

2015-06-26 08:59:31

by Antoine Tenart

Subject: Re: [PATCH 1/3] phy: berlin: .owner field is setup by core

On Wed, Jun 24, 2015 at 10:40:53AM +0200, Michal Simek wrote:
> There was big cleanup in past to remove this unneeded setting.
>
> Signed-off-by: Michal Simek <[email protected]>

Acked-by: Antoine Tenart <[email protected]>

> ---
>
> Can be also tracked by coccinelle script.
> scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> ---
> drivers/phy/phy-berlin-usb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index c6fc95b53083..d7431f6ab975 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -207,7 +207,6 @@ static struct platform_driver phy_berlin_usb_driver = {
> .probe = phy_berlin_usb_probe,
> .driver = {
> .name = "phy-berlin-usb",
> - .owner = THIS_MODULE,
> .of_match_table = phy_berlin_sata_of_match,
> },
> };
> --
> 2.3.5
>

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

2015-06-26 08:59:40

by Antoine Tenart

Subject: Re: [PATCH 3/3] usb: berlin: Trivial coding style cleanup

On Wed, Jun 24, 2015 at 10:40:55AM +0200, Michal Simek wrote:
> Remove unneeded space after tab.
>
> Signed-off-by: Michal Simek <[email protected]>

Acked-by: Antoine Tenart <[email protected]>

> ---
>
> drivers/phy/phy-berlin-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 762f0fbdc119..0fe0d81c29ee 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
> .driver = {
> .name = "phy-berlin-usb",
> .of_match_table = phy_berlin_usb_of_match,
> - },
> + },
> };
> module_platform_driver(phy_berlin_usb_driver);
>
> --
> 2.3.5
>

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

2015-06-26 09:00:16

by Antoine Tenart

Subject: Re: [PATCH 2/3] phy: berlin: Do not use sata name in usb phy driver

On Wed, Jun 24, 2015 at 10:40:54AM +0200, Michal Simek wrote:
> c&p error from berlin sata phy driver.
>
> Signed-off-by: Michal Simek <[email protected]>

Acked-by: Antoine Tenart <[email protected]>

> ---
>
> drivers/phy/phy-berlin-usb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index d7431f6ab975..762f0fbdc119 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
> .owner = THIS_MODULE,
> };
>
> -static const struct of_device_id phy_berlin_sata_of_match[] = {
> +static const struct of_device_id phy_berlin_usb_of_match[] = {
> {
> .compatible = "marvell,berlin2-usb-phy",
> .data = &phy_berlin_pll_dividers[0],
> @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
> },
> { },
> };
> -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
> +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
>
> static int phy_berlin_usb_probe(struct platform_device *pdev)
> {
> const struct of_device_id *match =
> - of_match_device(phy_berlin_sata_of_match, &pdev->dev);
> + of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> struct resource *res;
> struct phy *phy;
> @@ -207,7 +207,7 @@ static struct platform_driver phy_berlin_usb_driver = {
> .probe = phy_berlin_usb_probe,
> .driver = {
> .name = "phy-berlin-usb",
> - .of_match_table = phy_berlin_sata_of_match,
> + .of_match_table = phy_berlin_usb_of_match,
> },
> };
> module_platform_driver(phy_berlin_usb_driver);
> --
> 2.3.5
>

--
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

2015-07-15 12:44:05

by Kishon Vijay Abraham I

Subject: Re: [PATCH 3/3] usb: berlin: Trivial coding style cleanup

Hi,

On Friday 26 June 2015 02:29 PM, Antoine Tenart wrote:
> On Wed, Jun 24, 2015 at 10:40:55AM +0200, Michal Simek wrote:
>> Remove unneeded space after tab.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>
> Acked-by: Antoine Tenart <[email protected]>

Fixed $subject to have "phy" instead of "usb" and merged this series to
linux-phy tree.

Cheers
Kishon
>
>> ---
>>
>> drivers/phy/phy-berlin-usb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
>> index 762f0fbdc119..0fe0d81c29ee 100644
>> --- a/drivers/phy/phy-berlin-usb.c
>> +++ b/drivers/phy/phy-berlin-usb.c
>> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
>> .driver = {
>> .name = "phy-berlin-usb",
>> .of_match_table = phy_berlin_usb_of_match,
>> - },
>> + },
>> };
>> module_platform_driver(phy_berlin_usb_driver);
>>
>> --
>> 2.3.5
>>
>