2021-05-12 02:52:35

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] memory: da8xx-ddrctl: add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/memory/da8xx-ddrctl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/memory/da8xx-ddrctl.c b/drivers/memory/da8xx-ddrctl.c
index 872addd..7a51932 100644
--- a/drivers/memory/da8xx-ddrctl.c
+++ b/drivers/memory/da8xx-ddrctl.c
@@ -153,6 +153,7 @@ static const struct of_device_id da8xx_ddrctl_of_match[] = {
{ .compatible = "ti,da850-ddr-controller", },
{ },
};
+MODULE_DEVICE_TABLE(of, da8xx_ddrctl_of_match);

static struct platform_driver da8xx_ddrctl_driver = {
.probe = da8xx_ddrctl_probe,
--
2.6.2


2021-05-12 11:49:09

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH -next] memory: da8xx-ddrctl: add missing MODULE_DEVICE_TABLE

On 11/05/2021 23:08, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Thanks for the patch. Can you confirm that driver can be built as module?

>
> Reported-by: Hulk Robot <[email protected]>

Please make the reports public. This is open source work and public
collaboration.


Best regards,
Krzysztof