2024-02-23 14:32:31

by Paul Menzel

[permalink] [raw]
Subject: Re: [PATCH v1] linux-firmware: update firmware for mediatek bluetooth chip (MT7921)

Dear Chris,


Thank you for your patch. Some nits.

Am 23.02.24 um 10:50 schrieb Chris Lu:
> Update binary firmware for MT7921 BT devices.
>
> File: mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin
> Version: 20240219111427

The title is very unspecific for `git log --oneline`. Could you mention
the version number in there? Maybe:

linux-firmware: Update MediaTek MT7921 Bluetooth chip FW to 20240219111427

Also, could you please add a change-log of what changed between version
20231109191416 and 20240219111427?

> Signed-off-by: Chris Lu <[email protected]>
> ---
> WHENCE | 2 +-
> mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin | Bin 532206 -> 530926 bytes
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/WHENCE b/WHENCE
> index 576f8d73..f7dcc6db 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -5645,7 +5645,7 @@ Licence: Redistributable. See LICENCE.mediatek for details.
> Driver: mt7921 - MediaTek MT7921 bluetooth chipset
>
> File: mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin
> -Version: 20231109191416
> +Version: 20240219111427
>
> Licence: Redistributable. See LICENCE.mediatek for details.
>
> diff --git a/mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin b/mediatek/BT_RAM_CODE_MT7961_1_2_hdr.bin
> index c7a96755b122ef7aa601eb40fbd7abb9ca85a545..34b791b7cc66780a80a18a631a9d578b2a744546 100644
> GIT binary patch
> literal 530926

[…]


Kind regards,

Paul