2019-09-11 19:15:29

by Colin King

Subject: [PATCH] s390/qeth: fix spelling mistake "alocpool" -> "allocpool"

From: Colin Ian King <[email protected]>

There is a spelling mistake in QETH_CARD_TEXT text. Fix it.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/s390/net/qeth_core_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index a7868c8133ee..ab96b22db3fe 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -218,7 +218,7 @@ static int qeth_alloc_buffer_pool(struct qeth_card *card)
void *ptr;
int i, j;

- QETH_CARD_TEXT(card, 5, "alocpool");
+ QETH_CARD_TEXT(card, 5, "allocpool");
for (i = 0; i < card->qdio.init_pool.buf_count; ++i) {
pool_entry = kzalloc(sizeof(*pool_entry), GFP_KERNEL);
if (!pool_entry) {
--
2.20.1

2019-09-12 07:28:01

by Colin King

Subject: Re: [PATCH] s390/qeth: fix spelling mistake "alocpool" -> "allocpool"

On 12/09/2019 08:19, Ursula Braun wrote:
>
>
> On 9/11/19 5:35 PM, Colin King wrote:
>> From: Colin Ian King <[email protected]>
>>
>> There is a spelling mistake in QETH_CARD_TEXT text. Fix it.
>>
>
> This spelling mistake is intended, because this qeth trace area is defined for
> 8 byte length entries. We try to make the entries as speaking as possible - even
> at cost of spelling mistakes.

Ah, OK.

>
>> Signed-off-by: Colin Ian King <[email protected]>
>> ---
>> drivers/s390/net/qeth_core_main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
>> index a7868c8133ee..ab96b22db3fe 100644
>> --- a/drivers/s390/net/qeth_core_main.c
>> +++ b/drivers/s390/net/qeth_core_main.c
>> @@ -218,7 +218,7 @@ static int qeth_alloc_buffer_pool(struct qeth_card *card)
>> void *ptr;
>> int i, j;
>>
>> - QETH_CARD_TEXT(card, 5, "alocpool");
>> + QETH_CARD_TEXT(card, 5, "allocpool");
>> for (i = 0; i < card->qdio.init_pool.buf_count; ++i) {
>> pool_entry = kzalloc(sizeof(*pool_entry), GFP_KERNEL);
>> if (!pool_entry) {
>>
>

2019-09-12 07:43:20

by Ursula Braun

Subject: Re: [PATCH] s390/qeth: fix spelling mistake "alocpool" -> "allocpool"

On 9/11/19 5:35 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There is a spelling mistake in QETH_CARD_TEXT text. Fix it.
>

This spelling mistake is intended, because this qeth trace area is defined for
8 byte length entries. We try to make the entries as speaking as possible - even
at cost of spelling mistakes.

> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/s390/net/qeth_core_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index a7868c8133ee..ab96b22db3fe 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -218,7 +218,7 @@ static int qeth_alloc_buffer_pool(struct qeth_card *card)
> void *ptr;
> int i, j;
>
> - QETH_CARD_TEXT(card, 5, "alocpool");
> + QETH_CARD_TEXT(card, 5, "allocpool");
> for (i = 0; i < card->qdio.init_pool.buf_count; ++i) {
> pool_entry = kzalloc(sizeof(*pool_entry), GFP_KERNEL);
> if (!pool_entry) {
>