2022-09-09 08:36:34

by Aiqun Yu (Maria)

Subject: [PATCH] remoteproc: core: do pm relax when not first crash

Even if it is not first crash, need to relax the pm
wakelock otherwise the device will stay awake.

Change-Id: I26bfeb44871aab0b57837a77a6243b2086f94473
Signed-off-by: Maria Yu <[email protected]>
---
drivers/remoteproc/remoteproc_core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index e5279ed9a8d7..30078043e939 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1956,6 +1956,7 @@ static void rproc_crash_handler_work(struct work_struct *work)
if (rproc->state == RPROC_CRASHED || rproc->state == RPROC_OFFLINE) {
/* handle only the first crash detected */
mutex_unlock(&rproc->lock);
+ pm_relax(rproc->dev.parent);
return;
}

--
2.7.4

2022-09-09 08:56:13

by Aiqun Yu (Maria)

Subject: Re: [PATCH] remoteproc: core: do pm relax when not first crash

On 9/9/2022 4:05 PM, Maria Yu wrote:
> Even if it is not first crash, need to relax the pm
> wakelock otherwise the device will stay awake.
>
> Change-Id: I26bfeb44871aab0b57837a77a6243b2086f94473
Removed Change-Id in the later new patchset.
Pls ignore this.
> Signed-off-by: Maria Yu <[email protected]>
> ---
> drivers/remoteproc/remoteproc_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index e5279ed9a8d7..30078043e939 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1956,6 +1956,7 @@ static void rproc_crash_handler_work(struct work_struct *work)
> if (rproc->state == RPROC_CRASHED || rproc->state == RPROC_OFFLINE) {
> /* handle only the first crash detected */
> mutex_unlock(&rproc->lock);
> + pm_relax(rproc->dev.parent);
> return;
> }
>
>


--
Thx and BRs,
Aiqun(Maria) Yu