2020-04-06 02:32:17

by Wang Hai

Subject: [PATCH] bcache: remove set but not used variable 'i'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/md/bcache/btree.c: In function bch_btree_check_thread:
drivers/md/bcache/btree.c:1910:6: warning:
variable ‘i’ set but not used [-Wunused-but-set-variable]

It's not used since commit 8e7102273f59 ("bcache: make bch_btree_check()
to be multithreaded"), so remove it.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Hai <[email protected]>
---
drivers/md/bcache/btree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 72856e5..b962313 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -1907,10 +1907,10 @@ static int bch_btree_check_thread(void *arg)
struct btree_iter iter;
struct bkey *k, *p;
int cur_idx, prev_idx, skip_nr;
- int i, n;
+ int n;

k = p = NULL;
- i = n = 0;
+ n = 0;
cur_idx = prev_idx = 0;
ret = 0;

--
1.8.3.1

2020-04-06 04:43:58

by Coly Li

Subject: Re: [PATCH] bcache: remove set but not used variable 'i'

On 2020/4/7 7:36 下午, Wang Hai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/md/bcache/btree.c: In function bch_btree_check_thread:
> drivers/md/bcache/btree.c:1910:6: warning:
> variable ‘i’ set but not used [-Wunused-but-set-variable]
>
> It's not used since commit 8e7102273f59 ("bcache: make bch_btree_check()
> to be multithreaded"), so remove it.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wang Hai <[email protected]>

Hi Hai,

Colin King already submitted a similar patch on Apr 2 to fix it.

Thanks.

Coly Li


> ---
> drivers/md/bcache/btree.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 72856e5..b962313 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1907,10 +1907,10 @@ static int bch_btree_check_thread(void *arg)
> struct btree_iter iter;
> struct bkey *k, *p;
> int cur_idx, prev_idx, skip_nr;
> - int i, n;
> + int n;
>
> k = p = NULL;
> - i = n = 0;
> + n = 0;
> cur_idx = prev_idx = 0;
> ret = 0;
>
>

2020-04-06 06:40:08

by Wang Hai

Subject: Re: [PATCH] bcache: remove set but not used variable 'i'

在 2020/4/6 12:43, Coly Li 写道:
> On 2020/4/7 7:36 下午, Wang Hai wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/md/bcache/btree.c: In function bch_btree_check_thread:
>> drivers/md/bcache/btree.c:1910:6: warning:
>> variable ‘i’ set but not used [-Wunused-but-set-variable]
>>
>> It's not used since commit 8e7102273f59 ("bcache: make bch_btree_check()
>> to be multithreaded"), so remove it.
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Wang Hai <[email protected]>
> Hi Hai,
>
> Colin King already submitted a similar patch on Apr 2 to fix it.
>
> Thanks.
>
> Coly Li

Thanks for reminding, please ignore this patch.