2022-06-15 09:08:15

by Quan Nguyen

Subject: [PATCH v8 2/3] bindings: ipmi: Add binding for SSIF BMC driver

Add device tree binding document for the SSIF BMC driver.

Signed-off-by: Quan Nguyen <[email protected]>
---
v8:
+ None

v7:
+ Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]

v6:
+ None

v5:
+ None

v4:
+ Fix warning with dt_binding_check [Rob]
+ Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan]

v3:
+ Switched to use DT schema format [Rob]

v2:
+ None

.../devicetree/bindings/ipmi/ssif-bmc.yaml | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml

diff --git a/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml b/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
new file mode 100644
index 000000000000..02b662d780bb
--- /dev/null
+++ b/Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ipmi/ssif-bmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SSIF IPMI BMC interface
+
+description: SSIF IPMI BMC device bindings
+
+maintainers:
+ - Quan Nguyen <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - ssif-bmc
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ssif-bmc@10 {
+ compatible = "ssif-bmc";
+ reg = <0x10>;
+ };
+ };
--
2.35.1

2022-06-27 23:13:04

by Rob Herring (Arm)

Subject: Re: [PATCH v8 2/3] bindings: ipmi: Add binding for SSIF BMC driver

On Wed, Jun 15, 2022 at 04:02:58PM +0700, Quan Nguyen wrote:
> Add device tree binding document for the SSIF BMC driver.
>
> Signed-off-by: Quan Nguyen <[email protected]>
> ---
> v8:
> + None
>
> v7:
> + Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
>
> v6:
> + None
>
> v5:
> + None
>
> v4:
> + Fix warning with dt_binding_check [Rob]
> + Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan]
>
> v3:
> + Switched to use DT schema format [Rob]
>
> v2:
> + None
>
> .../devicetree/bindings/ipmi/ssif-bmc.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

2022-06-29 08:49:55

by Quan Nguyen

Subject: Re: [PATCH v8 2/3] bindings: ipmi: Add binding for SSIF BMC driver

On 28/06/2022 05:00, Rob Herring wrote:
> On Wed, Jun 15, 2022 at 04:02:58PM +0700, Quan Nguyen wrote:
>> Add device tree binding document for the SSIF BMC driver.
>>
>> Signed-off-by: Quan Nguyen <[email protected]>
>> ---
>> v8:
>> + None
>>
>> v7:
>> + Change compatible string from "ampere,ssif-bmc" to "ssif-bmc" [Jae]
>>
>> v6:
>> + None
>>
>> v5:
>> + None
>>
>> v4:
>> + Fix warning with dt_binding_check [Rob]
>> + Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml [Quan]
>>
>> v3:
>> + Switched to use DT schema format [Rob]
>>
>> v2:
>> + None
>>
>> .../devicetree/bindings/ipmi/ssif-bmc.yaml | 38 +++++++++++++++++++
>> 1 file changed, 38 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.

Dear Rob,

It was my fault and I apologize for forget adding your Reviewed-by tag
in this v8.
There is no change in this patch and the tag was not removed on purpose.
It's simply a mistake and I should have been more careful.

Will add the tag if there's new version and will be more careful next time.

Thank you and best regards,
- Quan