2022-11-16 10:57:18

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

The Qualcomm SM8550 platform has three instances of the tsens block,
add a compatible for these instances.

Signed-off-by: Neil Armstrong <[email protected]>
---
To: Andy Gross <[email protected]>
To: Bjorn Andersson <[email protected]>
To: Konrad Dybcio <[email protected]>
To: Amit Kucheria <[email protected]>
To: Thara Gopinath <[email protected]>
To: "Rafael J. Wysocki" <[email protected]>
To: Daniel Lezcano <[email protected]>
To: Zhang Rui <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index f0bd4b979e28..09dbd96d380e 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -58,6 +58,7 @@ properties:
- qcom,sm8250-tsens
- qcom,sm8350-tsens
- qcom,sm8450-tsens
+ - qcom,sm8550-tsens
- const: qcom,tsens-v2

- description: v2 of TSENS with combined interrupt

---
base-commit: 3c1f24109dfc4fb1a3730ed237e50183c6bb26b3
change-id: 20221114-narmstrong-sm8550-upstream-tsens-dfaec218c321

Best regards,
--
Neil Armstrong <[email protected]>


2022-11-16 11:52:08

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

On 16/11/2022 11:09, Neil Armstrong wrote:
> The Qualcomm SM8550 platform has three instances of the tsens block,
> add a compatible for these instances.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> To: Andy Gross <[email protected]>
> To: Bjorn Andersson <[email protected]>
> To: Konrad Dybcio <[email protected]>
> To: Amit Kucheria <[email protected]>
> To: Thara Gopinath <[email protected]>
> To: "Rafael J. Wysocki" <[email protected]>
> To: Daniel Lezcano <[email protected]>
> To: Zhang Rui <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index f0bd4b979e28..09dbd96d380e 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -58,6 +58,7 @@ properties:
> - qcom,sm8250-tsens
> - qcom,sm8350-tsens
> - qcom,sm8450-tsens
> + - qcom,sm8550-tsens

alOf:if:then should be updated.

Best regards,
Krzysztof


2022-11-17 09:14:05

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

Hi,

On 16/11/2022 12:26, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:09, Neil Armstrong wrote:
>> The Qualcomm SM8550 platform has three instances of the tsens block,
>> add a compatible for these instances.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> ---
>> To: Andy Gross <[email protected]>
>> To: Bjorn Andersson <[email protected]>
>> To: Konrad Dybcio <[email protected]>
>> To: Amit Kucheria <[email protected]>
>> To: Thara Gopinath <[email protected]>
>> To: "Rafael J. Wysocki" <[email protected]>
>> To: Daniel Lezcano <[email protected]>
>> To: Zhang Rui <[email protected]>
>> To: Rob Herring <[email protected]>
>> To: Krzysztof Kozlowski <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> ---
>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index f0bd4b979e28..09dbd96d380e 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -58,6 +58,7 @@ properties:
>> - qcom,sm8250-tsens
>> - qcom,sm8350-tsens
>> - qcom,sm8450-tsens
>> + - qcom,sm8550-tsens
>
> alOf:if:then should be updated.

I thought the -v2 fallback would be enough since 8450 isn't present either in the alOf:if:then either.

Anyway, will fix this.

Thanks,
Neil

>
> Best regards,
> Krzysztof
>


2022-11-17 13:26:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

On 17/11/2022 09:06, Neil Armstrong wrote:
> Hi,
>
> On 16/11/2022 12:26, Krzysztof Kozlowski wrote:
>> On 16/11/2022 11:09, Neil Armstrong wrote:
>>> The Qualcomm SM8550 platform has three instances of the tsens block,
>>> add a compatible for these instances.
>>>
>>> Signed-off-by: Neil Armstrong <[email protected]>
>>> ---
>>> To: Andy Gross <[email protected]>
>>> To: Bjorn Andersson <[email protected]>
>>> To: Konrad Dybcio <[email protected]>
>>> To: Amit Kucheria <[email protected]>
>>> To: Thara Gopinath <[email protected]>
>>> To: "Rafael J. Wysocki" <[email protected]>
>>> To: Daniel Lezcano <[email protected]>
>>> To: Zhang Rui <[email protected]>
>>> To: Rob Herring <[email protected]>
>>> To: Krzysztof Kozlowski <[email protected]>
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> ---
>>> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> index f0bd4b979e28..09dbd96d380e 100644
>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>> @@ -58,6 +58,7 @@ properties:
>>> - qcom,sm8250-tsens
>>> - qcom,sm8350-tsens
>>> - qcom,sm8450-tsens
>>> + - qcom,sm8550-tsens
>>
>> alOf:if:then should be updated.
>
> I thought the -v2 fallback would be enough since 8450 isn't present either in the alOf:if:then either.
>
> Anyway, will fix this.


No, you are right. The v2 fallback is already in several allOf:if:then,
so this should be fine.


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-11-20 07:54:10

by Amit Kucheria

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

On Wed, Nov 16, 2022 at 3:40 PM Neil Armstrong
<[email protected]> wrote:
>
> The Qualcomm SM8550 platform has three instances of the tsens block,
> add a compatible for these instances.
>
> Signed-off-by: Neil Armstrong <[email protected]>

Acked-by: Amit Kucheria <[email protected]>

> ---
> To: Andy Gross <[email protected]>
> To: Bjorn Andersson <[email protected]>
> To: Konrad Dybcio <[email protected]>
> To: Amit Kucheria <[email protected]>
> To: Thara Gopinath <[email protected]>
> To: "Rafael J. Wysocki" <[email protected]>
> To: Daniel Lezcano <[email protected]>
> To: Zhang Rui <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index f0bd4b979e28..09dbd96d380e 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -58,6 +58,7 @@ properties:
> - qcom,sm8250-tsens
> - qcom,sm8350-tsens
> - qcom,sm8450-tsens
> + - qcom,sm8550-tsens
> - const: qcom,tsens-v2
>
> - description: v2 of TSENS with combined interrupt
>
> ---
> base-commit: 3c1f24109dfc4fb1a3730ed237e50183c6bb26b3
> change-id: 20221114-narmstrong-sm8550-upstream-tsens-dfaec218c321
>
> Best regards,
> --
> Neil Armstrong <[email protected]>

2022-12-06 17:38:07

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: thermal: qcom-tsens: Add compatible for sm8550

On 16/11/2022 11:09, Neil Armstrong wrote:
> The Qualcomm SM8550 platform has three instances of the tsens block,
> add a compatible for these instances.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog