From: allen chen <[email protected]>
Add properties to restrict dp output data-lanes and clock.
Signed-off-by: Pin-Yen Lin <[email protected]>
Signed-off-by: Allen Chen <[email protected]>
---
.../bindings/display/bridge/ite,it6505.yaml | 68 +++++++++++++++++--
1 file changed, 62 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
index 833d11b2303a7..b16a9d9127ddb 100644
--- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
@@ -52,9 +52,49 @@ properties:
maxItems: 1
description: extcon specifier for the Power Delivery
- port:
- $ref: /schemas/graph.yaml#/properties/port
- description: A port node pointing to DPI host port node
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+
+ properties:
+ port@0:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: A port node pointing to DPI host port node
+
+ properties:
+ endpoint:
+ $ref: /schemas/graph.yaml#/$defs/endpoint-base
+ unevaluatedProperties: false
+
+ properties:
+ link-frequencies:
+ minItems: 1
+ maxItems: 1
+ description: Allowed max link frequencies in Hz
+
+ port@1:
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
+ description: Video port for DP output
+
+ properties:
+ endpoint:
+ $ref: /schemas/graph.yaml#/$defs/endpoint-base
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ minItems: 1
+ uniqueItems: true
+ items:
+ - enum: [ 0, 1 ]
+ - const: 1
+ - const: 2
+ - const: 3
+
+ required:
+ - port@0
+ - port@1
required:
- compatible
@@ -63,6 +103,7 @@ required:
- interrupts
- reset-gpios
- extcon
+ - ports
additionalProperties: false
@@ -85,9 +126,24 @@ examples:
reset-gpios = <&pio 179 1>;
extcon = <&usbc_extcon>;
- port {
- it6505_in: endpoint {
- remote-endpoint = <&dpi_out>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ it6505_in: endpoint {
+ remote-endpoint = <&dpi_out>;
+ link-frequencies = /bits/ 64 <150000000>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ it6505_out: endpoint {
+ remote-endpoint = <&dp_in>;
+ data-lanes = <0 1>;
+ };
};
};
};
--
2.25.1
On 26/10/2022 23:01, allen wrote:
> From: allen chen <[email protected]>
>
> Add properties to restrict dp output data-lanes and clock.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Rob asked - Commit msg should explain reason for breaking users.
>
> Signed-off-by: Pin-Yen Lin <[email protected]>
> Signed-off-by: Allen Chen <[email protected]>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 68 +++++++++++++++++--
> 1 file changed, 62 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a7..b16a9d9127ddb 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,9 +52,49 @@ properties:
> maxItems: 1
> description: extcon specifier for the Power Delivery
>
> - port:
> - $ref: /schemas/graph.yaml#/properties/port
> - description: A port node pointing to DPI host port node
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: A port node pointing to DPI host port node
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> + unevaluatedProperties: false
> +
> + properties:
> + link-frequencies:
> + minItems: 1
> + maxItems: 1
> + description: Allowed max link frequencies in Hz
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: Video port for DP output
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + minItems: 1
> + uniqueItems: true
> + items:
> + - enum: [ 0, 1 ]
> + - const: 1
> + - const: 2
> + - const: 3
> +
This looks ok.
Best regards,
Krzysztof
hi
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Friday, October 28, 2022 9:59 AM
To: Allen Chen (陳柏宇) <[email protected]>
Cc: Pin-Yen Lin <[email protected]>; Jau-Chih Tseng (曾昭智) <[email protected]>; Hermes Wu (吳佳宏) <[email protected]>; Kenneth Hung (洪家倫) <[email protected]>; Andrzej Hajda <[email protected]>; Neil Armstrong <[email protected]>; Robert Foss <[email protected]>; Laurent Pinchart <[email protected]>; Jonas Karlman <[email protected]>; Jernej Skrabec <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; open list:DRM DRIVERS <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; open list <[email protected]>
Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
On 26/10/2022 23:01, allen wrote:
> From: allen chen <[email protected]>
>
> Add properties to restrict dp output data-lanes and clock.
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all requested changes or keep discussing them.
Thank you.
==> I am sorry I didn't find the missing advice you said. Could you explain it again?
Rob asked - Commit msg should explain reason for breaking users.
>
> Signed-off-by: Pin-Yen Lin <[email protected]>
> Signed-off-by: Allen Chen <[email protected]>
> ---
> .../bindings/display/bridge/ite,it6505.yaml | 68 +++++++++++++++++--
> 1 file changed, 62 insertions(+), 6 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a7..b16a9d9127ddb 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,9 +52,49 @@ properties:
> maxItems: 1
> description: extcon specifier for the Power Delivery
>
> - port:
> - $ref: /schemas/graph.yaml#/properties/port
> - description: A port node pointing to DPI host port node
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: A port node pointing to DPI host port node
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> + unevaluatedProperties: false
> +
> + properties:
> + link-frequencies:
> + minItems: 1
> + maxItems: 1
> + description: Allowed max link frequencies in Hz
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description: Video port for DP output
> +
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + minItems: 1
> + uniqueItems: true
> + items:
> + - enum: [ 0, 1 ]
> + - const: 1
> + - const: 2
> + - const: 3
> +
This looks ok.
Best regards,
Krzysztof
On 02/11/2022 02:54, [email protected] wrote:
> On 26/10/2022 23:01, allen wrote:
>> From: allen chen <[email protected]>
>>
>> Add properties to restrict dp output data-lanes and clock.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested changes or keep discussing them.
>
> Thank you.
>
> ==> I am sorry I didn't find the missing advice you said. Could you explain it again?
>
> Rob asked - Commit msg should explain reason for breaking users.
And where is the reason? I saw only one sentence "Add properties to
restrict dp output data-lanes and clock."
Best regards,
Krzysztof
hi
-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, November 3, 2022 12:34 AM
To: Allen Chen (陳柏宇) <[email protected]>
Cc: [email protected]; Jau-Chih Tseng (曾昭智) <[email protected]>; Hermes Wu (吳佳宏) <[email protected]>; Kenneth Hung (洪家倫) <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth
On 02/11/2022 02:54, [email protected] wrote:
> On 26/10/2022 23:01, allen wrote:
>> From: allen chen <[email protected]>
>>
>> Add properties to restrict dp output data-lanes and clock.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested changes or keep discussing them.
>
> Thank you.
>
> ==> I am sorry I didn't find the missing advice you said. Could you explain it again?
>
> Rob asked - Commit msg should explain reason for breaking users.
And where is the reason? I saw only one sentence "Add properties to restrict dp output data-lanes and clock."
==> I will add the commit msg in v7. Thanks for the suggestion.
Best regards,
Krzysztof