2014-06-28 10:37:57

by Fabian Frédérick

Subject: [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: "K. Y. Srinivasan" <[email protected]>
Cc: Haiyang Zhang <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/hyperv/netvsc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 4ed38ea..f13e0ac 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1094,9 +1094,7 @@ close:
vmbus_close(device->channel);

cleanup:
-
- if (net_device)
- kfree(net_device);
+ kfree(net_device);

return ret;
}
--
1.8.4.5

2014-06-28 12:53:09

by Haiyang Zhang

Subject: RE: [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary null test before kfree

> -----Original Message-----
> From: Fabian Frederick [mailto:[email protected]]
> Sent: Saturday, June 28, 2014 6:37 AM
> To: [email protected]
> Cc: Fabian Frederick; KY Srinivasan; Haiyang Zhang;
> [email protected]
> Subject: [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary
> null test before kfree
>
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: "K. Y. Srinivasan" <[email protected]>
> Cc: Haiyang Zhang <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>

Reviewed-by: Haiyang Zhang <[email protected]>

Also, please add [email protected] to the recipients.
Thanks.