2016-11-16 15:30:15

by Arnd Bergmann

Subject: [PATCH] blk-bwt: fix old-style function declaration

The newly added driver causes a harmless warning in some configurations:

block/blk-wbt.c:250:1: error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration]
static bool inline stat_sample_valid(struct blk_rq_stat *stat)

This makes it use the expected format for the declaration.

Signed-off-by: Arnd Bergmann <[email protected]>
---
block/blk-wbt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 20712f0db6ea..9f97594e68ce 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -247,7 +247,7 @@ static bool calc_wb_limits(struct rq_wb *rwb)
return ret;
}

-static bool inline stat_sample_valid(struct blk_rq_stat *stat)
+static inline bool stat_sample_valid(struct blk_rq_stat *stat)
{
/*
* We need at least one read sample, and a minimum of
--
2.9.0

2016-11-16 15:33:51

by Jens Axboe

Subject: Re: [PATCH] blk-bwt: fix old-style function declaration

On 11/16/2016 08:29 AM, Arnd Bergmann wrote:
> The newly added driver causes a harmless warning in some configurations:
>
> block/blk-wbt.c:250:1: error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration]
> static bool inline stat_sample_valid(struct blk_rq_stat *stat)
>
> This makes it use the expected format for the declaration.

Thanks Arnd, applied with the subject typo fixed up.

--
Jens Axboe