2020-07-25 12:04:13

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init()

> The variable np in function m10v_smp_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it.

Such information is useful.


> If this node is not put it may cause a memory leak.

Is the reference management generally improvable for this function implementation?


Will the tag “Fixes” become helpful for the commit message?

Regards,
Markus