2024-04-28 12:09:37

by Chen shuo

Subject: [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis

This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis

Signed-off-by: pipishuo <[email protected]>
---
drivers/staging/axis-fifo/axis-fifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index c51818c56dd2..04f0e5b45a8b 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -376,7 +376,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
*/
mutex_lock(&fifo->read_lock);
ret = wait_event_interruptible_timeout(fifo->read_queue,
- ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+ ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
read_timeout);

if (ret <= 0) {
--
2.34.1

2024-04-28 14:00:03

by Dan Carpenter

Subject: Re: [PATCH] staging: axis-fifo: fixes alignment should match open parenthesis

On Sun, Apr 28, 2024 at 08:04:34PM +0800, pipishuo wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: pipishuo <[email protected]>

This is your legal name that you use to sign legal documents? Just one
word, all lower case?

> ---
> drivers/staging/axis-fifo/axis-fifo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index c51818c56dd2..04f0e5b45a8b 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -376,7 +376,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> read_timeout);

Checkpatch is just a tool. It's supposed to make the code more
readable. Sometimes it makes mistakes and makes the code worse.

If it tells you to do something crazy then just ignore it.

regards,
dan carpenter