Hi,
On 4/1/21 2:17 PM, Mauro Carvalho Chehab wrote:
> The file name: Documentation/ABI/testing/sysfs-platform_profile.rst
> should be, instead: Documentation/userspace-api/sysfs-platform_profile.rst.
>
> Update its cross-reference accordingly.
>
> Fixes: a2ff95e018f1 ("ACPI: platform: Add platform profile support")
> Fixes: 8e0cbf356377 ("Documentation: Add documentation for new platform_profile sysfs attribute")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <[email protected]>
Rafael, I assume you will merge this through your tree?
Regards,
Hans
> ---
> include/linux/platform_profile.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
> index a6329003aee7..e5cbb6841f3a 100644
> --- a/include/linux/platform_profile.h
> +++ b/include/linux/platform_profile.h
> @@ -2,7 +2,7 @@
> /*
> * Platform profile sysfs interface
> *
> - * See Documentation/ABI/testing/sysfs-platform_profile.rst for more
> + * See Documentation/userspace-api/sysfs-platform_profile.rst for more
> * information.
> */
>
>
On 01/04/2021 09:49, Hans de Goede wrote:
> Hi,
>
> On 4/1/21 2:17 PM, Mauro Carvalho Chehab wrote:
>> The file name: Documentation/ABI/testing/sysfs-platform_profile.rst
>> should be, instead: Documentation/userspace-api/sysfs-platform_profile.rst.
>>
>> Update its cross-reference accordingly.
>>
>> Fixes: a2ff95e018f1 ("ACPI: platform: Add platform profile support")
>> Fixes: 8e0cbf356377 ("Documentation: Add documentation for new platform_profile sysfs attribute")
>> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <[email protected]>
>
> Rafael, I assume you will merge this through your tree?
>
> Regards,
>
> Hans
>
Looks good to me too - though I'd missed the fact the file had moved
somehow :)
Not sure if my reviewed tag has any value but if it's useful:
Reviewed-by: Mark Pearson <[email protected]>
Just for my education - how do things get moved from testing to
somewhere else, is there a decision process etc?
Thank you!
Mark
>> ---
>> include/linux/platform_profile.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
>> index a6329003aee7..e5cbb6841f3a 100644
>> --- a/include/linux/platform_profile.h
>> +++ b/include/linux/platform_profile.h
>> @@ -2,7 +2,7 @@
>> /*
>> * Platform profile sysfs interface
>> *
>> - * See Documentation/ABI/testing/sysfs-platform_profile.rst for more
>> + * See Documentation/userspace-api/sysfs-platform_profile.rst for more
>> * information.
>> */
>>
>>
>
Hi,
On 4/1/21 5:07 PM, Mark Pearson wrote:
>
>
> On 01/04/2021 09:49, Hans de Goede wrote:
>> Hi,
>>
>> On 4/1/21 2:17 PM, Mauro Carvalho Chehab wrote:
>>> The file name: Documentation/ABI/testing/sysfs-platform_profile.rst
>>> should be, instead: Documentation/userspace-api/sysfs-platform_profile.rst.
>>>
>>> Update its cross-reference accordingly.
>>>
>>> Fixes: a2ff95e018f1 ("ACPI: platform: Add platform profile support")
>>> Fixes: 8e0cbf356377 ("Documentation: Add documentation for new platform_profile sysfs attribute")
>>> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>>
>> Thanks, patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <[email protected]>
>>
>> Rafael, I assume you will merge this through your tree?
>>
>> Regards,
>>
>> Hans
>>
> Looks good to me too - though I'd missed the fact the file had moved
> somehow :)
>
> Not sure if my reviewed tag has any value but if it's useful:
> Reviewed-by: Mark Pearson <[email protected]>
>
> Just for my education - how do things get moved from testing to
> somewhere else, is there a decision process etc?
I'm not sure how things work with the new Documentation/userspace-api/
dir, but with the old Documentation/ABI/testing dir things used to go
like this (AFAICT):
1) A new sysfs API bindings starts in Documentation/ABI/testing
2) This sysfs API bindings then stays in Documentation/ABI/testing forever
And if the bindings were actually in use by userspace then they were being
treated as immutable / unbreakable API anyways so the testing prefix
had very little meaning really.
Which I guess may well be the reason why new the new place no
longer has a testing prefix.
Regards,
Hans
>>> ---
>>> include/linux/platform_profile.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/platform_profile.h b/include/linux/platform_profile.h
>>> index a6329003aee7..e5cbb6841f3a 100644
>>> --- a/include/linux/platform_profile.h
>>> +++ b/include/linux/platform_profile.h
>>> @@ -2,7 +2,7 @@
>>> /*
>>> * Platform profile sysfs interface
>>> *
>>> - * See Documentation/ABI/testing/sysfs-platform_profile.rst for more
>>> + * See Documentation/userspace-api/sysfs-platform_profile.rst for more
>>> * information.
>>> */
>>>
>>>
>>
>