2021-06-01 08:20:42

by Zhihao Cheng

[permalink] [raw]
Subject: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhihao Cheng <[email protected]>
---
drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index b4f33dc399a0..78073ad1f2f1 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
if (IS_ERR(mbox->regs)) {
ret = PTR_ERR(mbox->regs);
- dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
goto fail;
}
regs_end = mbox->regs + resource_size(iomem);
--
2.31.1


2021-06-09 16:34:27

by Scott Branden

[permalink] [raw]
Subject: Re: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()

On 2021-06-09 5:13 a.m., Zhihao Cheng wrote:
> 在 2021/6/1 16:28, Zhihao Cheng 写道:
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Zhihao Cheng <[email protected]>
Acked-by: Scott Branden <[email protected]>
>> ---
>>   drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
>> index b4f33dc399a0..78073ad1f2f1 100644
>> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
>> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
>> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
>>       mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
>>       if (IS_ERR(mbox->regs)) {
>>           ret = PTR_ERR(mbox->regs);
>> -        dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
>>           goto fail;
>>       }
>>       regs_end = mbox->regs + resource_size(iomem);
>
> friendly ping.
>


Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2021-06-09 17:23:16

by Zhihao Cheng

[permalink] [raw]
Subject: Re: [PATCH] mailbox: bcm-flexrm-mailbox: Remove redundant dev_err call in flexrm_mbox_probe()

?? 2021/6/1 16:28, Zhihao Cheng д??:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhihao Cheng <[email protected]>
> ---
> drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index b4f33dc399a0..78073ad1f2f1 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1523,7 +1523,6 @@ static int flexrm_mbox_probe(struct platform_device *pdev)
> mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
> if (IS_ERR(mbox->regs)) {
> ret = PTR_ERR(mbox->regs);
> - dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);
> goto fail;
> }
> regs_end = mbox->regs + resource_size(iomem);

friendly ping.