2022-06-07 10:54:30

by Neil Armstrong

Subject: Re: [PATCH v6 5/5] mtd: rawnand: meson: not support legacy clock

Hi,

On 07/06/2022 08:47, Liang Yang wrote:
> meson NFC driver use common clock interfaces. so the test robot report
> some errors once using the legacy clock with HAVE_LEGACY_CLK on.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Liang Yang <[email protected]>
> ---
> drivers/mtd/nand/raw/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..5169412a4af4 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -395,7 +395,7 @@ config MTD_NAND_STM32_FMC2
>
> config MTD_NAND_MESON
> tristate "Support for NAND controller on Amlogic's Meson SoCs"
> - depends on ARCH_MESON || COMPILE_TEST
> + depends on ARCH_MESON || COMPILE_TEST || !HAVE_LEGACY_CLK

I think depending on CCF would be better than excluding legacy clock.

> select MFD_SYSCON
> help
> Enables support for NAND controller on Amlogic's Meson SoCs.

Neil

2022-06-07 17:55:09

by Liang Yang

Subject: Re: [PATCH v6 5/5] mtd: rawnand: meson: not support legacy clock

Hi Neil,

On 2022/6/7 15:12, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> Hi,
>
> On 07/06/2022 08:47, Liang Yang wrote:
>> meson NFC driver use common clock interfaces. so the test robot report
>> some errors once using the legacy clock with HAVE_LEGACY_CLK on.
>>
>> Reported-by: kernel test robot <[email protected]>
>> Signed-off-by: Liang Yang <[email protected]>
>> ---
>>   drivers/mtd/nand/raw/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
>> index 67b7cb67c030..5169412a4af4 100644
>> --- a/drivers/mtd/nand/raw/Kconfig
>> +++ b/drivers/mtd/nand/raw/Kconfig
>> @@ -395,7 +395,7 @@ config MTD_NAND_STM32_FMC2
>>   config MTD_NAND_MESON
>>       tristate "Support for NAND controller on Amlogic's Meson SoCs"
>> -    depends on ARCH_MESON || COMPILE_TEST
>> +    depends on ARCH_MESON || COMPILE_TEST || !HAVE_LEGACY_CLK
>
> I think depending on CCF would be better than excluding legacy clock.
>
indeed. i will use COMMON_CLK later. thanks.

>>       select MFD_SYSCON
>>       help
>>         Enables support for NAND controller on Amlogic's Meson SoCs.
>
> Neil
>
> .