Hi,
The following patch against 2.6.15 adds support for the http://www.Papouch.com
USB thermometer by adding the appropriate vendor and product id.
Signed off: Folkert van Heusden <[email protected]
diff -uNrbBd old/ftdi_sio.c new/ftdi_sio.c
--- old/ftdi_sio.c 2006-03-24 20:36:19.000000000 +0100
+++ new/ftdi_sio.c 2006-03-24 20:33:20.000000000 +0100
@@ -307,6 +307,7 @@
static struct usb_device_id id_table_combined [] = {
+ { USB_DEVICE(PAPOUCHE_VENDOR, PAPOUCHE_THEM_PROD) },
{ USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
diff -uNrbBd old/ftdi_sio.h new/ftdi_sio.h
--- old/ftdi_sio.h 2006-03-24 20:36:19.000000000 +0100
+++ new/ftdi_sio.h 2006-03-24 20:37:35.000000000 +0100
@@ -20,8 +20,13 @@
* Philipp G?hring - [email protected] - added the Device ID of the USB relais
* from Rudolf Gugler
*
+ * Folkert van Heusden - [email protected] - added the device id of the
+ * temperature sensor from http://www.papouch.com
*/
+#define PAPOUCHE_VENDOR 0x5050
+#define PAPOUCHE_THEM_PROD 0x0400
+
#define FTDI_VID 0x0403 /* Vendor Id */
#define FTDI_SIO_PID 0x8372 /* Product Id SIO application of 8U100AX */
#define FTDI_8U232AM_PID 0x6001 /* Similar device to SIO above */
Folkert van Heusden
--
http://www.vanheusden.com/multitail - multitail is tail on steroids. multiple
windows, filtering, coloring, anything you can think of
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, http://www.vanheusden.com
Folkert van Heusden wrote:
> The following patch against 2.6.15 adds support for the http://www.Papouch.com
> USB thermometer by adding the appropriate vendor and product id.
OK, this should probably work, but adding a new device support might require
a bit more effort...
And since I started looking into the code, I think it may see some
cleanup, so I'll be submitting shortly a series of two patches, yours included
as a second one. I'll CC you and please add the correct Signed-off-by line if
you agree and repost.
The page for this device is here:
http://www.papouch.com/shop/scripts/_detail.asp?katcislo=0188
Specs (in Polish) here:
http://www.papouch.com/shop/scripts/pdf/tmu.pdf
>
>
Be careful with this line:
> Signed off: Folkert van Heusden <[email protected]
Should be:
Signed-off-by: Folkert van Heusden <[email protected]>
> diff -uNrbBd old/ftdi_sio.c new/ftdi_sio.c
> --- old/ftdi_sio.c 2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.c 2006-03-24 20:33:20.000000000 +0100
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(PAPOUCHE_VENDOR, PAPOUCHE_THEM_PROD) },
What about:
s/PAPOUCHE_VENDOR/PAPOUCHE_VID/g
s/PAPOUCHE_THEM_PROD/PAPOUCHE_TMU_PID/g
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -uNrbBd old/ftdi_sio.h new/ftdi_sio.h
> --- old/ftdi_sio.h 2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.h 2006-03-24 20:37:35.000000000 +0100
> @@ -20,8 +20,13 @@
> * Philipp G?hring - [email protected] - added the Device ID of the USB relais
You are not using UTF-8 capable MUA or editor or both, so the umlaut is
broken here.
> * from Rudolf Gugler
> *
> + * Folkert van Heusden - [email protected] - added the device id of the
> + * temperature sensor from http://www.papouch.com
Credits are better with the PID/VID lines, not here. Just look at what
other (most) people have done.
add at least the name [TMU] here
> */
>
> +#define PAPOUCHE_VENDOR 0x5050
> +#define PAPOUCHE_THEM_PROD 0x0400
+#define PAPOUCHE_VID 0x5050
+#define PAPOUCHE_TMU_PID 0x0400
> +
> #define FTDI_VID 0x0403 /* Vendor Id */
> #define FTDI_SIO_PID 0x8372 /* Product Id SIO application of 8U100AX */
> #define FTDI_8U232AM_PID 0x6001 /* Similar device to SIO above */
IMHO, `diff -ruN` or `diff -pruN` should be better when posting patches :-)
Kalin.
--
|[ ~~~~~~~~~~~~~~~~~~~~~~ ]|
+-> http://ThinRope.net/ <-+
|[ ______________________ ]|
On Fri, Mar 24, 2006 at 08:46:55PM +0100, Folkert van Heusden wrote:
> Hi,
>
> The following patch against 2.6.15 adds support for the http://www.Papouch.com
> USB thermometer by adding the appropriate vendor and product id.
>
>
> Signed off: Folkert van Heusden <[email protected]
It should be "Signed-off-by:".
> diff -uNrbBd old/ftdi_sio.c new/ftdi_sio.c
> --- old/ftdi_sio.c 2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.c 2006-03-24 20:33:20.000000000 +0100
Can you make it so I can apply the patch from the root of the kernel
tree? Documentation/SubmittingPatches describes how to create a patch
in this way.
> @@ -307,6 +307,7 @@
>
>
> static struct usb_device_id id_table_combined [] = {
> + { USB_DEVICE(PAPOUCHE_VENDOR, PAPOUCHE_THEM_PROD) },
> { USB_DEVICE(FTDI_VID, FTDI_IRTRANS_PID) },
Your email client ate the tabs :(
> { USB_DEVICE(FTDI_VID, FTDI_SIO_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
> diff -uNrbBd old/ftdi_sio.h new/ftdi_sio.h
> --- old/ftdi_sio.h 2006-03-24 20:36:19.000000000 +0100
> +++ new/ftdi_sio.h 2006-03-24 20:37:35.000000000 +0100
> @@ -20,8 +20,13 @@
> * Philipp G?hring - [email protected] - added the Device ID of the USB relais
> * from Rudolf Gugler
> *
> + * Folkert van Heusden - [email protected] - added the device id of the
> + * temperature sensor from http://www.papouch.com
This information doesn't belong in the file, only in the changelog.
It's not needed.
Care to redo this?
thanks,
greg k-h