2023-03-09 22:50:57

by Sebastian Reichel

Subject: [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling

power-supply properties are reported in µV, µA and µW.
The IIO API provides mV, mA, mW, so the values need to
be multiplied by 1000.

Signed-off-by: Sebastian Reichel <[email protected]>
---
drivers/power/supply/generic-adc-battery.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
index 917bd2a6cc52..535972a332b3 100644
--- a/drivers/power/supply/generic-adc-battery.c
+++ b/drivers/power/supply/generic-adc-battery.c
@@ -136,6 +136,9 @@ static int read_channel(struct gab *adc_bat, enum power_supply_property psp,
result);
if (ret < 0)
pr_err("read channel error\n");
+ else
+ *result *= 1000;
+
return ret;
}

--
2.39.2

2023-03-10 08:23:27

by Linus Walleij

Subject: Re: [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling

On Thu, Mar 9, 2023 at 11:50 PM Sebastian Reichel <[email protected]> wrote:

> power-supply properties are reported in µV, µA and µW.
> The IIO API provides mV, mA, mW, so the values need to
> be multiplied by 1000.
>
> Signed-off-by: Sebastian Reichel <[email protected]>

Fixes: tag?
Cc: [email protected]

Reviewed-by: Linus Walleij <[email protected]>

This code can not have seen much testing.

Yours,
Linus Walleij

2023-03-13 07:53:35

by Matti Vaittinen

Subject: Re: [PATCHv1 04/11] power: supply: generic-adc-battery: fix unit scaling

On 3/10/23 00:50, Sebastian Reichel wrote:
> power-supply properties are reported in µV, µA and µW.
> The IIO API provides mV, mA, mW, so the values need to
> be multiplied by 1000.
>
> Signed-off-by: Sebastian Reichel <[email protected]>

As Linus wrote, Fixes-tag would be good. With that remark:
Reviewed-by: Matti Vaittinen <[email protected]>

> ---
> drivers/power/supply/generic-adc-battery.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
> index 917bd2a6cc52..535972a332b3 100644
> --- a/drivers/power/supply/generic-adc-battery.c
> +++ b/drivers/power/supply/generic-adc-battery.c
> @@ -136,6 +136,9 @@ static int read_channel(struct gab *adc_bat, enum power_supply_property psp,
> result);
> if (ret < 0)
> pr_err("read channel error\n");
> + else
> + *result *= 1000;
> +
> return ret;
> }
>

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~