2024-04-01 14:11:42

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/4] arm64: dts: stratix10: socdk: drop unneeded flash address/size-cells

Flash node uses single "partition" node to describe partitions, so
remove deprecated address/size-cells properties to also fix dtc W=1
warnings:

socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 26173f0b0051..4eee777ef1a1 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -180,8 +180,6 @@ rtc@68 {
&qspi {
status = "okay";
flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
compatible = "micron,mt25qu02g", "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <100000000>;
--
2.34.1



2024-04-01 14:11:53

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/4] arm64: dts: stratix10: socdk_nand: drop unneeded flash address/size-cells

Flash node uses single "partition" node to describe partitions, so
remove deprecated address/size-cells properties to also fix dtc W=1
warnings:

socfpga_stratix10_socdk_nand.dts:171.10-200.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
index 81d0e914a77c..7c53cb9621e5 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
@@ -169,8 +169,6 @@ rtc@68 {
&qspi {
status = "okay";
flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
compatible = "micron,mt25qu02g", "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <100000000>;
--
2.34.1


2024-04-01 14:12:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/4] arm64: dts: agilex: socdk: drop unneeded flash address/size-cells

Flash node uses single "partition" node to describe partitions, so
remove deprecated address/size-cells properties to also fix dtc W=1
warnings:

socfpga_agilex_socdk.dts:108.10-137.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index ad99aefeb185..b31cfa6b802d 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -106,8 +106,6 @@ &watchdog0 {
&qspi {
status = "okay";
flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
compatible = "micron,mt25qu02g", "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <100000000>;
--
2.34.1


2024-04-01 14:12:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 4/4] arm64: dts: n5x: socdk: drop unneeded flash address/size-cells

Flash node uses single "partition" node to describe partitions, so
remove deprecated address/size-cells properties to also fix dtc W=1
warnings:

socfpga_n5x_socdk.dts:85.10-114.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
index 2d70a92c2090..7952c7f47cc2 100644
--- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
@@ -83,8 +83,6 @@ &osc1 {
&qspi {
status = "okay";
flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
compatible = "micron,mt25qu02g", "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <100000000>;
--
2.34.1


2024-04-05 12:30:25

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 1/4] arm64: dts: stratix10: socdk: drop unneeded flash address/size-cells

On 4/1/24 09:10, Krzysztof Kozlowski wrote:
> Flash node uses single "partition" node to describe partitions, so
> remove deprecated address/size-cells properties to also fix dtc W=1
> warnings:
>
> socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 26173f0b0051..4eee777ef1a1 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -180,8 +180,6 @@ rtc@68 {
> &qspi {
> status = "okay";
> flash@0 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> compatible = "micron,mt25qu02g", "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <100000000>;

All patches applied!

Thanks,
Dinh

2024-06-04 10:07:21

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/4] arm64: dts: stratix10: socdk: drop unneeded flash address/size-cells

On 05/04/2024 14:30, Dinh Nguyen wrote:
> On 4/1/24 09:10, Krzysztof Kozlowski wrote:
>> Flash node uses single "partition" node to describe partitions, so
>> remove deprecated address/size-cells properties to also fix dtc W=1
>> warnings:
>>
>> socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
>> index 26173f0b0051..4eee777ef1a1 100644
>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
>> @@ -180,8 +180,6 @@ rtc@68 {
>> &qspi {
>> status = "okay";
>> flash@0 {
>> - #address-cells = <1>;
>> - #size-cells = <1>;
>> compatible = "micron,mt25qu02g", "jedec,spi-nor";
>> reg = <0>;
>> spi-max-frequency = <100000000>;
>
> All patches applied!

This was two months ago, so it should reach v6.10-rc1. It is neither in
v6.10-rc1 nor in linux-next.

Are you sure you applied this?

Are your trees in linux-next?

Best regards,
Krzysztof


2024-06-06 17:49:25

by Dinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH 1/4] arm64: dts: stratix10: socdk: drop unneeded flash address/size-cells

On 6/4/24 05:07, Krzysztof Kozlowski wrote:
> On 05/04/2024 14:30, Dinh Nguyen wrote:
>> On 4/1/24 09:10, Krzysztof Kozlowski wrote:
>>> Flash node uses single "partition" node to describe partitions, so
>>> remove deprecated address/size-cells properties to also fix dtc W=1
>>> warnings:
>>>
>>> socfpga_stratix10_socdk.dts:182.10-211.4: Warning (avoid_unnecessary_addr_size): /soc@0/spi@ff8d2000/flash@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
>>> index 26173f0b0051..4eee777ef1a1 100644
>>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
>>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
>>> @@ -180,8 +180,6 @@ rtc@68 {
>>> &qspi {
>>> status = "okay";
>>> flash@0 {
>>> - #address-cells = <1>;
>>> - #size-cells = <1>;
>>> compatible = "micron,mt25qu02g", "jedec,spi-nor";
>>> reg = <0>;
>>> spi-max-frequency = <100000000>;
>>
>> All patches applied!
>
> This was two months ago, so it should reach v6.10-rc1. It is neither in
> v6.10-rc1 nor in linux-next.
>
> Are you sure you applied this?
>
> Are your trees in linux-next?

I apologize, I miss the PR for the v6.10. I have it queue for v6.11.

Dinh