2021-07-27 05:42:42

by Cai,Huoqing

Subject: [PATCH] media: s3c-camif: Remove unused including <linux/version.h>

Remove including <linux/version.h> that don't need it.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/media/platform/s3c-camif/camif-core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
index e1d51fd3e700..64078cbfd7f9 100644
--- a/drivers/media/platform/s3c-camif/camif-core.c
+++ b/drivers/media/platform/s3c-camif/camif-core.c
@@ -23,7 +23,6 @@
#include <linux/pm_runtime.h>
#include <linux/slab.h>
#include <linux/types.h>
-#include <linux/version.h>

#include <media/media-device.h>
#include <media/v4l2-ctrls.h>
--
2.25.1

2021-07-27 20:54:31

by Randy Dunlap

Subject: Re: [PATCH] media: s3c-camif: Remove unused including <linux/version.h>

On 7/26/21 10:40 PM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Cai Huoqing <[email protected]>

as reported by 'make versioncheck':

../drivers/media/platform/s3c-camif/camif-core.c: 26 linux/version.h not needed.

Acked-by: Randy Dunlap <[email protected]>

thanks.

> ---
> drivers/media/platform/s3c-camif/camif-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
> index e1d51fd3e700..64078cbfd7f9 100644
> --- a/drivers/media/platform/s3c-camif/camif-core.c
> +++ b/drivers/media/platform/s3c-camif/camif-core.c
> @@ -23,7 +23,6 @@
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
> #include <linux/types.h>
> -#include <linux/version.h>
>
> #include <media/media-device.h>
> #include <media/v4l2-ctrls.h>
>


--
~Randy