Two trivial cleanups after recent changes in selftests/livepatch. Based
on "next" branch of Shuah's kselftest tree.
Miroslav Benes (2):
selftests/livepatch: Replace set_dynamic_debug() with setup_config()
in README
selftests/livepatch: Remove unused local variable in
set_ftrace_enabled()
tools/testing/selftests/livepatch/README | 2 +-
tools/testing/selftests/livepatch/functions.sh | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
--
2.24.1
Commit 35c9e74cff4c ("selftests/livepatch: Make dynamic debug setup and
restore generic") introduced setup_config() to set up the environment
for each test. It superseded set_dynamic_debug(). README still mentions
set_dynamic_debug(), so update it to setup_config() which should be used
now in every test.
Signed-off-by: Miroslav Benes <[email protected]>
---
tools/testing/selftests/livepatch/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/README b/tools/testing/selftests/livepatch/README
index b73cd0e2dd51..621d325425c2 100644
--- a/tools/testing/selftests/livepatch/README
+++ b/tools/testing/selftests/livepatch/README
@@ -35,7 +35,7 @@ Adding tests
------------
See the common functions.sh file for the existing collection of utility
-functions, most importantly set_dynamic_debug() and check_result(). The
+functions, most importantly setup_config() and check_result(). The
latter function greps the kernel's ring buffer for "livepatch:" and
"test_klp" strings, so tests be sure to include one of those strings for
result comparison. Other utility functions include general module
--
2.24.1
set_ftrace_enabled() contains unused local variable "sysctl". Remove it.
Signed-off-by: Miroslav Benes <[email protected]>
---
tools/testing/selftests/livepatch/functions.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/livepatch/functions.sh b/tools/testing/selftests/livepatch/functions.sh
index a6e3d5517a6f..2aab9791791d 100644
--- a/tools/testing/selftests/livepatch/functions.sh
+++ b/tools/testing/selftests/livepatch/functions.sh
@@ -64,7 +64,6 @@ function set_dynamic_debug() {
}
function set_ftrace_enabled() {
- local sysctl="$1"
result=$(sysctl kernel.ftrace_enabled="$1" 2>&1 | paste --serial --delimiters=' ')
echo "livepatch: $result" > /dev/kmsg
}
--
2.24.1
On 1/13/20 6:19 PM, Miroslav Benes wrote:
> Commit 35c9e74cff4c ("selftests/livepatch: Make dynamic debug setup and
> restore generic") introduced setup_config() to set up the environment
> for each test. It superseded set_dynamic_debug(). README still mentions
> set_dynamic_debug(), so update it to setup_config() which should be used
> now in every test.
>
> Signed-off-by: Miroslav Benes <[email protected]>
Reviewed-by: Kamalesh Babulal <[email protected]>
--
Kamalesh
On 1/13/20 6:19 PM, Miroslav Benes wrote:
> set_ftrace_enabled() contains unused local variable "sysctl". Remove it.
>
> Signed-off-by: Miroslav Benes <[email protected]>
Reviewed-by: Kamalesh Babulal <[email protected]>
--
Kamalesh
On 1/13/20 7:49 AM, Miroslav Benes wrote:
> Two trivial cleanups after recent changes in selftests/livepatch. Based
> on "next" branch of Shuah's kselftest tree.
>
> Miroslav Benes (2):
> selftests/livepatch: Replace set_dynamic_debug() with setup_config()
> in README
> selftests/livepatch: Remove unused local variable in
> set_ftrace_enabled()
>
> tools/testing/selftests/livepatch/README | 2 +-
> tools/testing/selftests/livepatch/functions.sh | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
For the series:
Acked-by: Joe Lawrence <[email protected]>
-- Joe
On Mon 2020-01-13 13:49:05, Miroslav Benes wrote:
> Two trivial cleanups after recent changes in selftests/livepatch. Based
> on "next" branch of Shuah's kselftest tree.
>
> Miroslav Benes (2):
> selftests/livepatch: Replace set_dynamic_debug() with setup_config()
> in README
> selftests/livepatch: Remove unused local variable in
> set_ftrace_enabled()
For the entire series:
Reviewed-by: Petr Mladek <[email protected]>
Shuah, would you like to take it via your selftest tree, please?
Best Regards,
Petr