The driver calls pci_request_regions() in probe and uses
pci_release_regions() in probe failure.
However, it calls pci_release_region() in remove, which does
match the other two calls.
Use pci_release_regions() instead to unify them.
Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/thermal/intel/intel_pch_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index 4f0bb8f502e1..5f7798b8d35f 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -365,7 +365,7 @@ static void intel_pch_thermal_remove(struct pci_dev *pdev)
thermal_zone_device_unregister(ptd->tzd);
iounmap(ptd->hw_base);
pci_set_drvdata(pdev, NULL);
- pci_release_region(pdev, 0);
+ pci_release_regions(pdev);
pci_disable_device(pdev);
}
--
2.24.0
On 06/12/2019 08:55, Chuhong Yuan wrote:
> The driver calls pci_request_regions() in probe and uses
> pci_release_regions() in probe failure.
> However, it calls pci_release_region() in remove, which does
> match the other two calls.
> Use pci_release_regions() instead to unify them.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
Applied, thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
On Fri, 2019-12-06 at 15:55 +0800, Chuhong Yuan wrote:
> The driver calls pci_request_regions() in probe and uses
> pci_release_regions() in probe failure.
> However, it calls pci_release_region() in remove, which does
> match the other two calls.
> Use pci_release_regions() instead to unify them.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
Acked-by: Zhang Rui <[email protected]>
> ---
> drivers/thermal/intel/intel_pch_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> b/drivers/thermal/intel/intel_pch_thermal.c
> index 4f0bb8f502e1..5f7798b8d35f 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -365,7 +365,7 @@ static void intel_pch_thermal_remove(struct
> pci_dev *pdev)
> thermal_zone_device_unregister(ptd->tzd);
> iounmap(ptd->hw_base);
> pci_set_drvdata(pdev, NULL);
> - pci_release_region(pdev, 0);
> + pci_release_regions(pdev);
> pci_disable_device(pdev);
> }
>