2024-04-18 22:59:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] dt-bindings: display: panel: Add KD101NE3-40TI support

On 18/04/2024 10:15, lvzhaoxiong wrote:
> Create a new dt-scheam for the kd101ne3-40ti.

There is another thread like this, which is confusing. Please version
your patches. patman solves it. b4 as well.

Read the guidelines provided to you by Google.

>
> Signed-off-by: lvzhaoxiong <[email protected]>

Same comment as for all your other patches: please use full name.

> ---
> .../panel/kingdisplay,kd101ne3-40ti.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml
> new file mode 100644
> index 000000000000..dc79a49eea3b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd101ne3-40ti.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/kingdisplay,kd101ne3-40ti.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: King Display KD035G6-40TI based MIPI-DSI panels
> +
> +description: |
> + -This binding is for display panels using an JD9365DA controller
> +
> +maintainers:
> + - Zhaoxiong Lv <[email protected]>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: kingdisplay,kd101ne3-40ti
> +
> + backlight: true
> + port: true

Drop both

> + pp3300-supply: true
> + reg: true
> + enable-gpios: true
> + rotation: true

Drop these three. panel-common defines them.

> +
> +required:
> + - compatible
> + - reg
> + - enable-gpios
> + - pp3300-supply
> + - backlight
> + - port

These can stay.

> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel: panel@0 {
> + compatible = "kingdisplay,kd101ne3-40ti";
> + reg = <0>;
> + enable-gpios = <&pio 98 0>;

You included the header, so use it.



Best regards,
Krzysztof