2022-08-26 12:46:07

by Huqiang Qin

Subject: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h

In the future, meson-s4.dtsi will have some nodes that need
to use the meson-s4-gpio.h file.

e.g.
* Bluetooth enable pin:
bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
* Audio mute pin:
spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
* ...

Signed-off-by: Huqiang Qin <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
index ad50cba42d19..44cce8b0fcef 100644
--- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
@@ -6,6 +6,7 @@
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/gpio/meson-s4-gpio.h>

/ {
cpus {
--
2.37.1

2022-08-26 18:08:00

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h

On 26/08/2022 15:23, Huqiang Qin wrote:
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
>
> e.g.
> * Bluetooth enable pin:
> bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> * Audio mute pin:
> spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
> * ...

Then the header should be added when the need is implemented. Do not add
unused headers to files.

Best regards,
Krzysztof

2022-08-29 04:58:19

by Huqiang Qin

Subject: Re: [PATCH v2] arm64: dts: meson-s4: include meson-s4-gpio.h

Hi Krzysztof,

On 2022/8/27 1:40, Krzysztof Kozlowski wrote:
> Then the header should be added when the need is implemented. Do not add
> unused headers to files.

I understand, thank you very much.

Best regards,
Huqiang