2022-11-22 02:17:48

by ye.xingchen

Subject: [PATCH] PM / devfreq: event: use devm_platform_get_and_ioremap_resource()

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Minghao Chi <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/devfreq/event/exynos-nocp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
index ccc531ee6938..c1cc23bcb995 100644
--- a/drivers/devfreq/event/exynos-nocp.c
+++ b/drivers/devfreq/event/exynos-nocp.c
@@ -214,8 +214,7 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev,
nocp->clk = NULL;

/* Maps the memory mapped IO to control nocp register */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(base))
return PTR_ERR(base);

--
2.25.1

2022-12-02 23:45:43

by Chanwoo Choi

Subject: Re: [PATCH] PM / devfreq: event: use devm_platform_get_and_ioremap_resource()

On 22. 11. 22. 10:42, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Minghao Chi <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/devfreq/event/exynos-nocp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
> index ccc531ee6938..c1cc23bcb995 100644
> --- a/drivers/devfreq/event/exynos-nocp.c
> +++ b/drivers/devfreq/event/exynos-nocp.c
> @@ -214,8 +214,7 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev,
> nocp->clk = NULL;
>
> /* Maps the memory mapped IO to control nocp register */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>

Applied it. Thanks.

--
Best Regards,
Samsung Electronics
Chanwoo Choi