2022-06-22 05:12:51

by Chang Yu

Subject: [PATCH 0/5] staging: r8188eu: Fixed some coding style issues

Fixed a few coding style issues as per checkpatch.pl and kernel coding
style guidelines.

Chang Yu (5):
staging: r8188eu: Fixed a function declaration coding style issue
staging: r8188eu: Fixed two brace coding style issues
staging: r8188eu: Fixed two whitespace coding style issues
staging: r8188eu: Fixed comment style
staging: r8188eu: Fixed some blank line coding style issues

drivers/staging/r8188eu/core/rtw_recv.c | 38 +++++++++++++++----------
1 file changed, 23 insertions(+), 15 deletions(-)

--
2.36.1

2022-06-22 05:16:03

by Chang Yu

Subject: [PATCH 5/5] staging: r8188eu: Fixed some blank line coding style issues

Added blank lines after variable declarations as per checkpatch.pl

Signed-off-by: Chang Yu <[email protected]>
---
drivers/staging/r8188eu/core/rtw_recv.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index 14dd2344fa4b..cc91638a085d 100644
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -237,6 +237,7 @@ u32 rtw_free_uc_swdec_pending_queue(struct adapter *adapter)
{
u32 cnt = 0;
struct recv_frame *pending_frame;
+
while ((pending_frame = rtw_alloc_recvframe(&adapter->recvpriv.uc_swdec_pending_queue))) {
rtw_free_recvframe(pending_frame, &adapter->recvpriv.free_recv_queue);
cnt++;
@@ -327,6 +328,7 @@ static struct recv_frame *decryptor(struct adapter *padapter, struct recv_frame

if (prxattrib->encrypt > 0) {
u8 *iv = precv_frame->rx_data + prxattrib->hdrlen;
+
prxattrib->key_index = (((iv[3]) >> 6) & 0x3);

if (prxattrib->key_index > WEP_KEYS) {
@@ -777,6 +779,7 @@ static int sta2ap_data_frame(struct adapter *adapter,
}
} else {
u8 *myhwaddr = myid(&adapter->eeprompriv);
+
if (memcmp(pattrib->ra, myhwaddr, ETH_ALEN)) {
ret = RTW_RX_HANDLED;
goto exit;
@@ -1022,6 +1025,7 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precv

if (pmlmeext->sitesurvey_res.state == SCAN_PROCESS) {
int ch_set_idx = rtw_ch_set_search_ch(pmlmeext->channel_set, rtw_get_oper_ch(adapter));
+
if (ch_set_idx >= 0)
pmlmeext->channel_set[ch_set_idx].rx_count++;
}
@@ -1049,6 +1053,7 @@ static int validate_recv_frame(struct adapter *adapter, struct recv_frame *precv
retval = validate_recv_data_frame(adapter, precv_frame);
if (retval == _FAIL) {
struct recv_priv *precvpriv = &adapter->recvpriv;
+
precvpriv->rx_drop++;
}
}
@@ -1312,9 +1317,11 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe)
struct rx_pkt_attrib *pattrib;
unsigned char *data_ptr;
struct sk_buff *sub_skb, *subframes[MAX_SUBFRAME_COUNT];
+
struct recv_priv *precvpriv = &padapter->recvpriv;
struct __queue *pfree_recv_queue = &precvpriv->free_recv_queue;
int ret = _SUCCESS;
+
nr_subframes = 0;

pattrib = &prframe->attrib;
--
2.36.1

2022-06-22 05:26:24

by Philipp Hortmann

Subject: Re: [PATCH 0/5] staging: r8188eu: Fixed some coding style issues

On 6/22/22 06:52, Chang Yu wrote:
> Fixed a few coding style issues as per checkpatch.pl and kernel coding
> style guidelines.
>
> Chang Yu (5):
> staging: r8188eu: Fixed a function declaration coding style issue
> staging: r8188eu: Fixed two brace coding style issues
> staging: r8188eu: Fixed two whitespace coding style issues
> staging: r8188eu: Fixed comment style
> staging: r8188eu: Fixed some blank line coding style issues
>
> drivers/staging/r8188eu/core/rtw_recv.c | 38 +++++++++++++++----------
> 1 file changed, 23 insertions(+), 15 deletions(-)
>

Tested-by: Philipp Hortmann <[email protected]> # Edimax N150
Adapter