2020-07-13 13:21:01

by Alexander A. Klimov

[permalink] [raw]
Subject: [PATCH] extcon: Replace HTTP links with HTTPS ones

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
(Actually letting a shell for loop submit all this stuff for me.)

If there are any URLs to be removed completely or at least not just HTTPSified:
Just clearly say so and I'll *undo my change*.
See also: https://lkml.org/lkml/2020/6/27/64

If there are any valid, but yet not changed URLs:
See: https://lkml.org/lkml/2020/6/26/837

If you apply the patch, please let me know.

Sorry again to all maintainers who complained about subject lines.
Now I realized that you want an actually perfect prefixes,
not just subsystem ones.
I tried my best...
And yes, *I could* (at least half-)automate it.
Impossible is nothing! :)


drivers/extcon/extcon-palmas.c | 2 +-
drivers/extcon/extcon-usb-gpio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index cea58d0cb457..e8e9eebe6b1d 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -2,7 +2,7 @@
/*
* Palmas USB transceiver driver
*
- * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com
+ * Copyright (C) 2013 Texas Instruments Incorporated - https://www.ti.com
* Author: Graeme Gregory <[email protected]>
* Author: Kishon Vijay Abraham I <[email protected]>
* Based on twl6030_usb.c
diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index 98b5afa5b615..f06be6d4e2a9 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -2,7 +2,7 @@
/**
* drivers/extcon/extcon-usb-gpio.c - USB GPIO extcon driver
*
- * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com
+ * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com
* Author: Roger Quadros <[email protected]>
*/

--
2.27.0


2020-08-25 03:53:59

by Chanwoo Choi

[permalink] [raw]
Subject: Re: [PATCH] extcon: Replace HTTP links with HTTPS ones

Hi,

On 7/13/20 10:19 PM, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely or at least not just HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://protect2.fireeye.com/url?k=dd645f97-80b64932-dd65d4d8-0cc47a31bee8-e21cf64490b8937b&q=1&u=https%3A%2F%2Flkml.org%2Flkml%2F2020%2F6%2F27%2F64
>
> If there are any valid, but yet not changed URLs:
> See: https://protect2.fireeye.com/url?k=815617a2-dc840107-81579ced-0cc47a31bee8-f16575a44dddc110&q=1&u=https%3A%2F%2Flkml.org%2Flkml%2F2020%2F6%2F26%2F837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> drivers/extcon/extcon-palmas.c | 2 +-
> drivers/extcon/extcon-usb-gpio.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index cea58d0cb457..e8e9eebe6b1d 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -2,7 +2,7 @@
> /*
> * Palmas USB transceiver driver
> *
> - * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com
> + * Copyright (C) 2013 Texas Instruments Incorporated - https://www.ti.com
> * Author: Graeme Gregory <[email protected]>
> * Author: Kishon Vijay Abraham I <[email protected]>
> * Based on twl6030_usb.c
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index 98b5afa5b615..f06be6d4e2a9 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -2,7 +2,7 @@
> /**
> * drivers/extcon/extcon-usb-gpio.c - USB GPIO extcon driver
> *
> - * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com
> + * Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com
> * Author: Roger Quadros <[email protected]>
> */
>
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics