2020-12-03 01:21:09

by Stephen Boyd

Subject: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

This is already handed by default in spi_setup() if the bits_per_word is
0, so just drop it to shave off a line.

Cc: Simon Glass <[email protected]>
Cc: Gwendal Grignou <[email protected]>
Cc: Douglas Anderson <[email protected]>
Cc: Alexandru M Stan <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/platform/chrome/cros_ec_spi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
index f9df218fc2bb..14c4046fa04d 100644
--- a/drivers/platform/chrome/cros_ec_spi.c
+++ b/drivers/platform/chrome/cros_ec_spi.c
@@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
struct cros_ec_spi *ec_spi;
int err;

- spi->bits_per_word = 8;
spi->rt = true;
err = spi_setup(spi);
if (err < 0)
--
https://chromeos.dev

2020-12-03 01:22:41

by Doug Anderson

Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

Hi,

On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd <[email protected]> wrote:
>
> This is already handed by default in spi_setup() if the bits_per_word is
> 0, so just drop it to shave off a line.
>
> Cc: Simon Glass <[email protected]>
> Cc: Gwendal Grignou <[email protected]>
> Cc: Douglas Anderson <[email protected]>
> Cc: Alexandru M Stan <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
> drivers/platform/chrome/cros_ec_spi.c | 1 -
> 1 file changed, 1 deletion(-)

Reviewed-by: Douglas Anderson <[email protected]>

2020-12-04 09:18:25

by Enric Balletbo i Serra

Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

Hi Stephen,

Thank you for your patch.

On 3/12/20 2:16, Stephen Boyd wrote:
> This is already handed by default in spi_setup() if the bits_per_word is
> 0, so just drop it to shave off a line.
>
> Cc: Simon Glass <[email protected]>
> Cc: Gwendal Grignou <[email protected]>
> Cc: Douglas Anderson <[email protected]>
> Cc: Alexandru M Stan <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

Acked-by: Enric Balletbo i Serra <[email protected]>

> ---
> drivers/platform/chrome/cros_ec_spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index f9df218fc2bb..14c4046fa04d 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
> struct cros_ec_spi *ec_spi;
> int err;
>
> - spi->bits_per_word = 8;
> spi->rt = true;
> err = spi_setup(spi);
> if (err < 0)
>