2024-05-30 23:44:08

by Doug Anderson

Subject: [PATCH REPOST net-next 2/2] r8152: Wake up the system if the we need a reset

If we get to the end of the r8152's suspend() routine and we find that
the USB device is INACCESSIBLE then it means that some of our
preparation for suspend didn't take place. We need a USB reset to get
ourselves back in a consistent state so we can try again and that
can't happen during system suspend. Call pm_wakeup_event() to wake the
system up in this case.

Signed-off-by: Douglas Anderson <[email protected]>
---

drivers/net/usb/r8152.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 6a3f4b2114ee..09fe70bc45d4 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -8647,6 +8647,13 @@ static int rtl8152_system_suspend(struct r8152 *tp)
tasklet_enable(&tp->tx_tl);
}

+ /* If we're inaccessible here then some of the work that we did to
+ * get the adapter ready for suspend didn't work. Queue up a wakeup
+ * event so we can try again.
+ */
+ if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
+ pm_wakeup_event(&tp->udev->dev, 0);
+
return 0;
}

--
2.45.1.288.g0e0cd299f1-goog

2024-06-03 06:41:12

by Hayes Wang

Subject: RE: [PATCH REPOST net-next 2/2] r8152: Wake up the system if the we need a reset

Douglas Anderson <[email protected]>
> Sent: Friday, May 31, 2024 7:43 AM
[...]
> If we get to the end of the r8152's suspend() routine and we find that
> the USB device is INACCESSIBLE then it means that some of our
> preparation for suspend didn't take place. We need a USB reset to get
> ourselves back in a consistent state so we can try again and that
> can't happen during system suspend. Call pm_wakeup_event() to wake the
> system up in this case.
>
> Signed-off-by: Douglas Anderson <[email protected]>

Acked-by: Hayes Wang <[email protected]>

Best Regards,
Hayes