2023-07-12 00:36:12

by kernel test robot

[permalink] [raw]
Subject: drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups'

Hi Sricharan,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
commit: 725d1c8916583f9c09e5f05e5a55dd47fdca61c1 pinctrl: qcom: Add IPQ5018 pinctrl driver
date: 5 weeks ago
config: arm64-randconfig-r015-20230712 (https://download.01.org/0day-ci/archive/20230712/[email protected]/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce: (https://download.01.org/0day-ci/archive/20230712/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
static const char * const _groups[] = {
^
1 warning generated.


vim +/_groups +244 drivers/pinctrl/qcom/pinctrl-ipq5018.c

243
> 244 static const char * const _groups[] = {
245 "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
246 "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
247 "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
248 "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
249 "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
250 "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
251 "gpio43", "gpio44", "gpio45", "gpio46",
252 };
253

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


2023-07-20 19:25:02

by Linus Walleij

[permalink] [raw]
Subject: Re: drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups'

Hi Srirachan, Bjorn,

is this warning valid or something I should ignore?

Yours,
Linus Walleij

On Wed, Jul 12, 2023 at 2:32 AM kernel test robot <[email protected]> wrote:
>
> Hi Sricharan,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
> commit: 725d1c8916583f9c09e5f05e5a55dd47fdca61c1 pinctrl: qcom: Add IPQ5018 pinctrl driver
> date: 5 weeks ago
> config: arm64-randconfig-r015-20230712 (https://download.01.org/0day-ci/archive/20230712/[email protected]/config)
> compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
> reproduce: (https://download.01.org/0day-ci/archive/20230712/[email protected]/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
> static const char * const _groups[] = {
> ^
> 1 warning generated.
>
>
> vim +/_groups +244 drivers/pinctrl/qcom/pinctrl-ipq5018.c
>
> 243
> > 244 static const char * const _groups[] = {
> 245 "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> 246 "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> 247 "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> 248 "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> 249 "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> 250 "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> 251 "gpio43", "gpio44", "gpio45", "gpio46",
> 252 };
> 253
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

2023-07-21 04:48:47

by Sricharan Ramabadhran

[permalink] [raw]
Subject: Re: drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups'

Hi Linus,

On 7/21/2023 12:51 AM, Linus Walleij wrote:
> Hi Srirachan, Bjorn,
>
> is this warning valid or something I should ignore?
>

oops, will fix this and send a separate patch.
Did not see this with the default defconfig build though.

Regards,
Sricharan