2023-01-05 15:10:29

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 0/3] Convert to *_with_info() API

On Thu, Jan 05, 2023 at 03:19:08PM +0100, Armin Wolf wrote:
> This patch series converts the ftsteutates driver to the *_with_info()
> API, reducing module size by ~30%.
> The first patch does the actual conversion, while the second patch deals
> with the nonstandard fanX_source attributes, which are being replaced
> with the standard pwmX_auto_channels_temp attributes. The last patch
> adds support for fanX_fault attributes.
>
> All patches where tested on a Fujitsu DS3401-B1.
>

This is the second time in less than two weeks that I get a follow-up
version of a patch series, unversioned and without change log.

That makes me wonder - is that just coincidence or is someone promoting
that ?

Guenter

> Armin Wolf (3):
> hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info()
> hwmon: (ftsteutates) Replace fanX_source with pwmX_auto_channels_temp
> hwmon: (ftsteutates) Add support for fanX_fault attributes
>
> Documentation/hwmon/ftsteutates.rst | 5 +
> drivers/hwmon/ftsteutates.c | 550 +++++++++++-----------------
> 2 files changed, 210 insertions(+), 345 deletions(-)
>
> --
> 2.30.2
>


2023-01-05 23:31:56

by Armin Wolf

[permalink] [raw]
Subject: Re: [PATCH 0/3] Convert to *_with_info() API

Am 05.01.23 um 15:57 schrieb Guenter Roeck:

> On Thu, Jan 05, 2023 at 03:19:08PM +0100, Armin Wolf wrote:
>> This patch series converts the ftsteutates driver to the *_with_info()
>> API, reducing module size by ~30%.
>> The first patch does the actual conversion, while the second patch deals
>> with the nonstandard fanX_source attributes, which are being replaced
>> with the standard pwmX_auto_channels_temp attributes. The last patch
>> adds support for fanX_fault attributes.
>>
>> All patches where tested on a Fujitsu DS3401-B1.
>>
> This is the second time in less than two weeks that I get a follow-up
> version of a patch series, unversioned and without change log.
>
> That makes me wonder - is that just coincidence or is someone promoting
> that ?
>
> Guenter

My fault, i thought that with all other patches of the previous series being merged
and the single remaining patch being significantly changed, it would be more appropriate
to create a new series.

I will send the patches as a follow-up series of the previous patch series then.

Armin Wolf

>> Armin Wolf (3):
>> hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info()
>> hwmon: (ftsteutates) Replace fanX_source with pwmX_auto_channels_temp
>> hwmon: (ftsteutates) Add support for fanX_fault attributes
>>
>> Documentation/hwmon/ftsteutates.rst | 5 +
>> drivers/hwmon/ftsteutates.c | 550 +++++++++++-----------------
>> 2 files changed, 210 insertions(+), 345 deletions(-)
>>
>> --
>> 2.30.2
>>