2017-07-17 06:01:26

by Sean Wang

Subject: [PATCH v2] clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call

From: Sean Wang <[email protected]>

Fixed the signedness bug returning '(-22)' on the return type as u8 with
removing the sanity checker in clk_cpumux_get_parent() since
clk_cpumux_set_parent() always ensures validity in clk_cpumux_get_parent()
got called.

Fixes: commit 1e17de9049da ("clk: mediatek: add missing cpu mux causing Mediatek cpufreq can't work")
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Sean Wang <[email protected]>
---
drivers/clk/mediatek/clk-cpumux.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c
index edd8e69..347d799 100644
--- a/drivers/clk/mediatek/clk-cpumux.c
+++ b/drivers/clk/mediatek/clk-cpumux.c
@@ -27,7 +27,6 @@ static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw *_hw)
static u8 clk_cpumux_get_parent(struct clk_hw *hw)
{
struct mtk_clk_cpumux *mux = to_mtk_clk_cpumux(hw);
- int num_parents = clk_hw_get_num_parents(hw);
unsigned int val;

regmap_read(mux->regmap, mux->reg, &val);
@@ -35,9 +34,6 @@ static u8 clk_cpumux_get_parent(struct clk_hw *hw)
val >>= mux->shift;
val &= mux->mask;

- if (val >= num_parents)
- return -EINVAL;
-
return val;
}

--
2.7.4

2017-07-18 01:17:52

by Stephen Boyd

Subject: Re: [PATCH v2] clk: mediatek: fixed static checker warning in clk_cpumux_get_parent call

On 07/17, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> Fixed the signedness bug returning '(-22)' on the return type as u8 with
> removing the sanity checker in clk_cpumux_get_parent() since
> clk_cpumux_set_parent() always ensures validity in clk_cpumux_get_parent()
> got called.
>
> Fixes: commit 1e17de9049da ("clk: mediatek: add missing cpu mux causing Mediatek cpufreq can't work")
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Sean Wang <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project