2020-01-19 13:27:41

by chenzhou

Subject: [PATCH -next] i40e: remove unnecessary conversions to bool

The conversions to bool are not needed, remove these.

Signed-off-by: Chen Zhou <[email protected]>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 33912cf..24cacfa 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1630,7 +1630,7 @@ static int i40e_config_rss_aq(struct i40e_vsi *vsi, const u8 *seed,
}
}
if (lut) {
- bool pf_lut = vsi->type == I40E_VSI_MAIN ? true : false;
+ bool pf_lut = vsi->type == I40E_VSI_MAIN;

ret = i40e_aq_set_rss_lut(hw, vsi->id, pf_lut, lut, lut_size);
if (ret) {
@@ -11455,7 +11455,7 @@ static int i40e_get_rss_aq(struct i40e_vsi *vsi, const u8 *seed,
}

if (lut) {
- bool pf_lut = vsi->type == I40E_VSI_MAIN ? true : false;
+ bool pf_lut = vsi->type == I40E_VSI_MAIN;

ret = i40e_aq_get_rss_lut(hw, vsi->id, pf_lut, lut, lut_size);
if (ret) {
--
2.7.4

2020-01-23 00:41:17

by Bowers, AndrewX

Subject: RE: [Intel-wired-lan] [PATCH -next] i40e: remove unnecessary conversions to bool

> -----Original Message-----
> From: Intel-wired-lan [mailto:[email protected]] On
> Behalf Of Chen Zhou
> Sent: Sunday, January 19, 2020 5:22 AM
> To: Kirsher, Jeffrey T <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; intel-wired-
> [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH -next] i40e: remove unnecessary
> conversions to bool
>
> The conversions to bool are not needed, remove these.
>
> Signed-off-by: Chen Zhou <[email protected]>
> ---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Andrew Bowers <[email protected]>