From: Takashi Sakamoto <[email protected]>
commit acd46a6b6de88569654567810acad2b0a0a25cea upstream.
Avid Adrenaline is reported that ALSA firewire-digi00x driver is bound to.
However, as long as he investigated, the design of this model is hardly
similar to the one of Digi 00x family. It's better to exclude the model
from modalias of ALSA firewire-digi00x driver.
This commit changes device entries so that the model is excluded.
$ python3 crpp < ~/git/am-config-rom/misc/avid-adrenaline.img
ROM header and bus information block
-----------------------------------------------------------------
400 04203a9c bus_info_length 4, crc_length 32, crc 15004
404 31333934 bus_name "1394"
408 e064a002 irmc 1, cmc 1, isc 1, bmc 0, cyc_clk_acc 100, max_rec 10 (2048)
40c 00a07e01 company_id 00a07e |
410 00085257 device_id 0100085257 | EUI-64 00a07e0100085257
root directory
-----------------------------------------------------------------
414 0005d08c directory_length 5, crc 53388
418 0300a07e vendor
41c 8100000c --> descriptor leaf at 44c
420 0c008380 node capabilities
424 8d000002 --> eui-64 leaf at 42c
428 d1000004 --> unit directory at 438
eui-64 leaf at 42c
-----------------------------------------------------------------
42c 0002410f leaf_length 2, crc 16655
430 00a07e01 company_id 00a07e |
434 00085257 device_id 0100085257 | EUI-64 00a07e0100085257
unit directory at 438
-----------------------------------------------------------------
438 0004d6c9 directory_length 4, crc 54985
43c 1200a02d specifier id: 1394 TA
440 13014001 version: Vender Unique and AV/C
444 17000001 model
448 81000009 --> descriptor leaf at 46c
descriptor leaf at 44c
-----------------------------------------------------------------
44c 00077205 leaf_length 7, crc 29189
450 00000000 textual descriptor
454 00000000 minimal ASCII
458 41766964 "Avid"
45c 20546563 " Tec"
460 686e6f6c "hnol"
464 6f677900 "ogy"
468 00000000
descriptor leaf at 46c
-----------------------------------------------------------------
46c 000599a5 leaf_length 5, crc 39333
470 00000000 textual descriptor
474 00000000 minimal ASCII
478 41647265 "Adre"
47c 6e616c69 "nali"
480 6e650000 "ne"
Reported-by: Simon Wood <[email protected]>
Fixes: 9edf723fd858 ("ALSA: firewire-digi00x: add skeleton for Digi 002/003 family")
Cc: <[email protected]> # 4.4+
Signed-off-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
sound/firewire/digi00x/digi00x.c | 5 +++++
1 file changed, 5 insertions(+)
--- a/sound/firewire/digi00x/digi00x.c
+++ b/sound/firewire/digi00x/digi00x.c
@@ -15,6 +15,7 @@ MODULE_LICENSE("GPL v2");
#define VENDOR_DIGIDESIGN 0x00a07e
#define MODEL_CONSOLE 0x000001
#define MODEL_RACK 0x000002
+#define SPEC_VERSION 0x000001
static int name_card(struct snd_dg00x *dg00x)
{
@@ -185,14 +186,18 @@ static const struct ieee1394_device_id s
/* Both of 002/003 use the same ID. */
{
.match_flags = IEEE1394_MATCH_VENDOR_ID |
+ IEEE1394_MATCH_VERSION |
IEEE1394_MATCH_MODEL_ID,
.vendor_id = VENDOR_DIGIDESIGN,
+ .version = SPEC_VERSION,
.model_id = MODEL_CONSOLE,
},
{
.match_flags = IEEE1394_MATCH_VENDOR_ID |
+ IEEE1394_MATCH_VERSION |
IEEE1394_MATCH_MODEL_ID,
.vendor_id = VENDOR_DIGIDESIGN,
+ .version = SPEC_VERSION,
.model_id = MODEL_RACK,
},
{}
On 2020-09-08 09:26, Greg Kroah-Hartman wrote:
> From: Takashi Sakamoto <[email protected]>
>
> commit acd46a6b6de88569654567810acad2b0a0a25cea upstream.
>
> Avid Adrenaline is reported that ALSA firewire-digi00x driver is bound
> to.
> However, as long as he investigated, the design of this model is hardly
> similar to the one of Digi 00x family. It's better to exclude the model
> from modalias of ALSA firewire-digi00x driver.
>
> This commit changes device entries so that the model is excluded.
>
Just to add my 'ACK-BY'. Yes, the Avid Adrenaline seems to be based
around a totally different method of control and will likely need a
separate driver.
I believe that this includes the following devices: AVID Adrenaline,
AVID Mojo, AVID Mojo SDI, AVID AV Option and others... from Windows
driver 'FlameThrower' inf.
--
[AvidHardware.NTx86]
%Avid_Gryphon% = Flamethrower, 1394\Avid_Technology&Gryphon
%Avid_Raven% = Flamethrower, 1394\Avid_Technology&Raven
%Avid_Adrenaline% = Flamethrower, 1394\Avid_Technology&Adrenaline
%Avid_FireBobPro% = Flamethrower, 1394\Avid_Technology&FireBobPro
%Avid_Mojo% = Flamethrower, 1394\Avid_Technology&Mojo
%Avid_FireBoB% = Flamethrower, 1394\Avid_Technology&FireBoB
%Avid_FireBoBV2% = Flamethrower, 1394\Avid_Technology&FireBoBV2
%Avid_DigiBoB% = Flamethrower, 1394\Avid_Technology&DigiBoB
%Avid_AVoptionV10% = Flamethrower, 1394\Avid_Technology&AVoptionV10
--
There are some details in this thread, for anyone interested in
following up.
https://sourceforge.net/p/ffado/mailman/message/37078754/
Cheers,
Simon.
PS. Have a Mojo SDI inbound, will confirm when it arrives.