2020-04-21 03:42:25

by Jason Yan

Subject: [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c

Fix the following coccicheck warning:

drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon

Signed-off-by: Jason Yan <[email protected]>
---
drivers/scsi/fcoe/fcoe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 25dae9f0b205..cb41d166e0c0 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
case FCOE_CTLR_ENABLED:
case FCOE_CTLR_UNUSED:
fcoe_ctlr_link_up(ctlr);
- };
+ }
} else if (fcoe_ctlr_link_down(ctlr)) {
switch (cdev->enabled) {
case FCOE_CTLR_DISABLED:
@@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
stats->LinkFailureCount++;
put_cpu();
fcoe_clean_pending_queue(lport);
- };
+ }
}
out:
return rc;
--
2.21.1

2020-04-21 05:47:39

by Hannes Reinecke

Subject: Re: [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c

On 4/21/20 5:40 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
> drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/scsi/fcoe/fcoe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index 25dae9f0b205..cb41d166e0c0 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1915,7 +1915,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
> case FCOE_CTLR_ENABLED:
> case FCOE_CTLR_UNUSED:
> fcoe_ctlr_link_up(ctlr);
> - };
> + }
> } else if (fcoe_ctlr_link_down(ctlr)) {
> switch (cdev->enabled) {
> case FCOE_CTLR_DISABLED:
> @@ -1927,7 +1927,7 @@ static int fcoe_device_notification(struct notifier_block *notifier,
> stats->LinkFailureCount++;
> put_cpu();
> fcoe_clean_pending_queue(lport);
> - };
> + }
> }
> out:
> return rc;
>
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

2020-04-22 04:13:04

by Martin K. Petersen

Subject: Re: [PATCH] scsi: fcoe: remove unneeded semicolon in fcoe.c

Jason,

> Fix the following coccicheck warning:
>
> drivers/scsi/fcoe/fcoe.c:1918:3-4: Unneeded semicolon
> drivers/scsi/fcoe/fcoe.c:1930:3-4: Unneeded semicolon

Applied to 5.8/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering