2022-04-14 06:17:48

by Pavel Skripkin

Subject: Re: [PATCH 5/6] staging: r8188eu: replace spaces with tabs

Hi Jaehee,

On 4/13/22 23:11, Jaehee Park wrote:
> Use tabs instead of spaces. Issue found with checkpatch.
> WARNING: suspect code indent for conditional statements
>
> Signed-off-by: Jaehee Park <[email protected]>
> ---
> drivers/staging/r8188eu/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> index b943fb190e4c..7a90fe826d1d 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> @@ -722,7 +722,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
> pmlmepriv->to_join = false;
> s_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
> if (s_ret == _SUCCESS) {
> - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT);
> + _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT);
> } else if (s_ret == 2) { /* there is no need to wait for join */
> _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);
> rtw_indicate_connect(adapter);

Not related to your patch, but looks like `s_ret` can't be 2.

rtw_select_and_join_from_scanned_queue

rtw_joinbss_cmd

rtw_enqueue_cmd
_rtw_enqueue_cmd <- always returns SUCCESS


Other functions from calltrace may return _FAIL, but _FAIL is not equal
2, right?



With regards,
Pavel Skripkin

2022-04-16 00:37:55

by Jaehee Park

Subject: Re: [PATCH 5/6] staging: r8188eu: replace spaces with tabs

On Wed, Apr 13, 2022 at 11:34:14PM +0300, Pavel Skripkin wrote:
> Hi Jaehee,
>
> On 4/13/22 23:11, Jaehee Park wrote:
> > Use tabs instead of spaces. Issue found with checkpatch.
> > WARNING: suspect code indent for conditional statements
> >
> > Signed-off-by: Jaehee Park <[email protected]>
> > ---
> > drivers/staging/r8188eu/core/rtw_mlme.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> > index b943fb190e4c..7a90fe826d1d 100644
> > --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> > @@ -722,7 +722,7 @@ void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf)
> > pmlmepriv->to_join = false;
> > s_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
> > if (s_ret == _SUCCESS) {
> > - _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT);
> > + _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT);
> > } else if (s_ret == 2) { /* there is no need to wait for join */
> > _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);
> > rtw_indicate_connect(adapter);
>
> Not related to your patch, but looks like `s_ret` can't be 2.
>
> rtw_select_and_join_from_scanned_queue
>
> rtw_joinbss_cmd
>
> rtw_enqueue_cmd
> _rtw_enqueue_cmd <- always returns SUCCESS
>
>
> Other functions from calltrace may return _FAIL, but _FAIL is not equal 2,
> right?
>

Thank you for your comment. Since _rtw_enqueue_cmd cn't return 2,
should we replace 2 with _FAIL? I can make this change in another
patch.

>
>
> With regards,
> Pavel Skripkin